Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 909093003: Parsing: Make Scope not know about Isolate. (Closed)

Created:
5 years, 10 months ago by marja
Modified:
5 years, 10 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Parsing: Make Scope not know about Isolate. Scope, like Parser, must be able to operate independent of Isolate and the V8 heap (for background parsing). After the heap-independent phase, there is a heap dependent phase, during which we do operations such as scope anaylysis. This CL makes the phases explicit by not telling Scope about the Isolate too early (during the heap-independent phase, Scope should know nothing about Isolate). This decreases the probability of accidental code changes which would add heap-dependent operations into the heap-independent phase. R=rossberg@chromium.org BUG= Committed: https://crrev.com/5d68529be240a1fc9fcc67c8950ead4baf7604e4 Cr-Commit-Position: refs/heads/master@{#26546}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -79 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/preparser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/scopes.h View 6 chunks +10 lines, -14 lines 0 comments Download
M src/scopes.cc View 15 chunks +46 lines, -51 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
marja
rossberg, ptal. moar refactoring.
5 years, 10 months ago (2015-02-10 13:59:40 UTC) #1
rossberg
lgtm
5 years, 10 months ago (2015-02-10 14:37:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/909093003/1
5 years, 10 months ago (2015-02-10 14:37:52 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-10 14:39:08 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 14:39:44 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d68529be240a1fc9fcc67c8950ead4baf7604e4
Cr-Commit-Position: refs/heads/master@{#26546}

Powered by Google App Engine
This is Rietveld 408576698