src/x64/full-codegen-x64.cc - Issue 909093003: Parsing: Make Scope not know about Isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/full-codegen-x64.cc

Issue 909093003: Parsing: Make Scope not know about Isolate. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/full-codegen-x64.cc

diff --git a/src/x64/full-codegen-x64.cc b/src/x64/full-codegen-x64.cc

index b248dd1ebbf88f200e6ac44acdf87683e402f47c..65e60fb855368667302c9cab27e7dce5c1a3bca7 100644

--- a/src/x64/full-codegen-x64.cc

+++ b/src/x64/full-codegen-x64.cc

@@ -189,7 +189,7 @@ void FullCodeGenerator::Generate() {

// Argument to NewContext is the function, which is still in rdi.

if (FLAG_harmony_scoping && info->scope()->is_script_scope()) {

__ Push(rdi);

- __ Push(info->scope()->GetScopeInfo());

+ __ Push(info->scope()->GetScopeInfo(info->isolate()));

__ CallRuntime(Runtime::kNewScriptContext, 2);

} else if (heap_slots <= FastNewContextStub::kMaximumSlots) {

FastNewContextStub stub(isolate(), heap_slots);

« no previous file with comments | « src/scopes.cc ('k') | test/cctest/test-parsing.cc » ('j') | no next file with comments »