Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 909043003: FileReader.result attribute should use IDL union types to avoid using custom binding. (Closed)

Created:
5 years, 10 months ago by vivekg_samsung
Modified:
5 years, 10 months ago
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, Inactive, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

FileReader.result attribute should use IDL union types to avoid using custom binding. The spec [1] mentions the result can be a DOMString or ArrayBuffer. Using the union type to remove the custom binding. R=jl@opera.com, haraken@chromium.org BUG=345519 [1] http://dev.w3.org/2006/webapi/FileAPI/#filedata-attr Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190094

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -71 lines) Patch
D Source/bindings/core/v8/custom/V8FileReaderCustom.cpp View 1 chunk +0 lines, -51 lines 0 comments Download
M Source/bindings/core/v8/custom/custom.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/fileapi/FileReader.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/fileapi/FileReader.cpp View 3 chunks +12 lines, -14 lines 0 comments Download
M Source/core/fileapi/FileReader.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/InspectorFileSystemAgent.cpp View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
vivekg
PTAL, thanks.
5 years, 10 months ago (2015-02-12 06:51:36 UTC) #2
vivekg
PTAL thank you.
5 years, 10 months ago (2015-02-12 06:54:16 UTC) #3
Jens Widell
LGTM (mostly non-owner) Thanks for eliminating custom bindings!
5 years, 10 months ago (2015-02-12 07:11:08 UTC) #4
vivekg
On 2015/02/12 at 07:11:08, jl wrote: > LGTM (mostly non-owner) > > Thanks for eliminating ...
5 years, 10 months ago (2015-02-12 08:29:49 UTC) #5
vivekg
haraken@, pfeldman@: friendly ping, thank you.
5 years, 10 months ago (2015-02-13 01:39:08 UTC) #7
haraken
On 2015/02/13 01:39:08, vivekg_ wrote: > haraken@, pfeldman@: friendly ping, thank you. Sorry I missed ...
5 years, 10 months ago (2015-02-13 01:46:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/909043003/1
5 years, 10 months ago (2015-02-13 01:52:28 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 01:55:31 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190094

Powered by Google App Engine
This is Rietveld 408576698