Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Unified Diff: Source/core/fileapi/FileReader.h

Issue 909043003: FileReader.result attribute should use IDL union types to avoid using custom binding. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/custom/custom.gypi ('k') | Source/core/fileapi/FileReader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/fileapi/FileReader.h
diff --git a/Source/core/fileapi/FileReader.h b/Source/core/fileapi/FileReader.h
index 8f1b00cb2233896faa852a97b5e79a381b01888e..81f4c1907eb3af5e0246778565c76d6f12142495 100644
--- a/Source/core/fileapi/FileReader.h
+++ b/Source/core/fileapi/FileReader.h
@@ -46,6 +46,7 @@ class Blob;
class DOMArrayBuffer;
class ExceptionState;
class ExecutionContext;
+class StringOrArrayBuffer;
class FileReader final : public RefCountedGarbageCollectedEventTargetWithInlineData<FileReader>, public ActiveDOMObject, public FileReaderLoaderClient {
DEFINE_WRAPPERTYPEINFO();
@@ -73,9 +74,7 @@ public:
ReadyState readyState() const { return m_state; }
FileError* error() { return m_error; }
- FileReaderLoader::ReadType readType() const { return m_readType; }
- PassRefPtr<DOMArrayBuffer> arrayBufferResult() const;
- String stringResult();
+ void result(StringOrArrayBuffer& resultAttribute) const;
// ActiveDOMObject
virtual void stop() override;
« no previous file with comments | « Source/bindings/core/v8/custom/custom.gypi ('k') | Source/core/fileapi/FileReader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698