Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 909013004: use conics for round joins and caps (Closed)

Created:
5 years, 10 months ago by reed2
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

use conics for round joins and caps BUG=skia:

Patch Set 1 #

Patch Set 2 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -9 lines) Patch
M src/core/SkGeometry.h View 2 chunks +0 lines, -2 lines 1 comment Download
M src/core/SkGeometry.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkStrokerPriv.cpp View 3 chunks +26 lines, -6 lines 2 comments Download

Messages

Total messages: 10 (4 generated)
reed2
ptal
5 years, 10 months ago (2015-02-10 04:20:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/909013004/20001
5 years, 10 months ago (2015-02-10 04:21:19 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-10 04:21:19 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 10 months ago (2015-02-10 10:21:20 UTC) #7
caryclark
lgtm https://codereview.chromium.org/909013004/diff/20001/src/core/SkGeometry.h File src/core/SkGeometry.h (left): https://codereview.chromium.org/909013004/diff/20001/src/core/SkGeometry.h#oldcode9 src/core/SkGeometry.h:9: accidental whitespace change? https://codereview.chromium.org/909013004/diff/20001/src/core/SkStrokerPriv.cpp File src/core/SkStrokerPriv.cpp (right): https://codereview.chromium.org/909013004/diff/20001/src/core/SkStrokerPriv.cpp#newcode46 ...
5 years, 10 months ago (2015-02-10 11:59:34 UTC) #8
reed1
5 years, 10 months ago (2015-02-10 15:15:20 UTC) #10

Powered by Google App Engine
This is Rietveld 408576698