Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: src/compiler.cc

Issue 908883002: new classes: implement new.target passing to superclass constructor. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix subclassing 'null' Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index e9cc11172664b92470eb0a9d0c530b4cbd3e303f..b1aa5b5fb1ff2f6c29f271364a0f824b8396b726 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -619,7 +619,11 @@ static void SetFunctionInfo(Handle<SharedFunctionInfo> function_info,
bool is_toplevel,
Handle<Script> script) {
function_info->set_length(lit->parameter_count());
- function_info->set_formal_parameter_count(lit->parameter_count());
+ if (FLAG_experimental_classes && IsSubclassConstructor(lit->kind())) {
+ function_info->set_formal_parameter_count(lit->parameter_count() + 1);
arv (Not doing code reviews) 2015/02/09 17:44:39 I'm worried about doing it at this high abstractio
+ } else {
+ function_info->set_formal_parameter_count(lit->parameter_count());
+ }
function_info->set_script(*script);
function_info->set_function_token_position(lit->function_token_position());
function_info->set_start_position(lit->start_position());
« no previous file with comments | « src/code-stubs.h ('k') | src/compiler/pipeline.cc » ('j') | src/runtime/runtime-object.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698