new classes: implement new.target passing to superclass constructor.

src/compiler.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/compiler.h"
 
 #include "src/ast-numbering.h"
 #include "src/ast-this-access-visitor.h"
@@ skipping 601 matching lines @@
 
 // Sets the function info on a function.
 // The start_position points to the first '(' character after the function name
 // in the full script source. When counting characters in the script source the
 // the first character is number 0 (not 1).
 static void SetFunctionInfo(Handle<SharedFunctionInfo> function_info,
                             FunctionLiteral* lit,
                             bool is_toplevel,
                             Handle<Script> script) {
   function_info->set_length(lit->parameter_count());
-  function_info->set_formal_parameter_count(lit->parameter_count());
+  if (FLAG_experimental_classes && IsSubclassConstructor(lit->kind())) {
+    function_info->set_formal_parameter_count(lit->parameter_count() + 1);

[arv (Not doing code reviews), 2015/02/09 17:44:39]

I'm worried about doing it at this high abstraction level. NewTarget is not a
formal parameter. Maybe it is better do it at a lower level abstraction in case
other code wants to use the formal parameter count for what it sounds like
(function length, rest params etc).

The SFI already has a field for the FunctionKind so deferring this choice seems
safer.

+  } else {
+    function_info->set_formal_parameter_count(lit->parameter_count());
+  }
   function_info->set_script(*script);
   function_info->set_function_token_position(lit->function_token_position());
   function_info->set_start_position(lit->start_position());
   function_info->set_end_position(lit->end_position());
   function_info->set_is_expression(lit->is_expression());
   function_info->set_is_anonymous(lit->is_anonymous());
   function_info->set_is_toplevel(is_toplevel);
   function_info->set_inferred_name(*lit->inferred_name());
   function_info->set_allows_lazy_compilation(lit->AllowsLazyCompilation());
   function_info->set_allows_lazy_compilation_without_context(
@@ skipping 976 matching lines @@
 }
 
 
 #if DEBUG
 void CompilationInfo::PrintAstForTesting() {
   PrintF("--- Source from AST ---\n%s\n",
          PrettyPrinter(isolate(), zone()).PrintProgram(function()));
 }
 #endif
 } }  // namespace v8::internal