Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issue 908883002: new classes: implement new.target passing to superclass constructor. (Closed)

Created:
5 years, 10 months ago by Dmitry Lomov (no reviews)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

new classes: implement new.target passing to superclass constructor. R=arv@chromium.org,rossberg@chromium.org BUG=v8:3834 LOG=N Committed: https://crrev.com/8aed43e82c6d2742fe5988603cb8841324cc942b Cr-Commit-Position: refs/heads/master@{#26560} Committed: https://crrev.com/bf49be39f333bf1ce14202663595d455aa4b24cb Cr-Commit-Position: refs/heads/master@{#26572}

Patch Set 1 #

Patch Set 2 : Fix subclassing 'null' #

Total comments: 6

Patch Set 3 : Rename of formal_parameter_count + moar tests #

Patch Set 4 : x64 (crashing yet) #

Patch Set 5 : x64 fixed #

Patch Set 6 : arm #

Patch Set 7 : arm64 #

Patch Set 8 : Test #

Total comments: 23

Patch Set 9 : Patch for landing #

Patch Set 10 : Fix x64 arithmetic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+500 lines, -139 lines) Patch
M src/accessors.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M src/arm/builtins-arm.cc View 1 2 3 4 5 3 chunks +6 lines, -1 line 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 3 4 5 5 chunks +16 lines, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 1 2 3 4 5 6 7 8 5 chunks +19 lines, -4 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 2 3 4 5 6 3 chunks +6 lines, -3 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 4 5 6 5 chunks +17 lines, -1 line 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 2 3 4 5 6 7 8 5 chunks +19 lines, -4 lines 0 comments Download
M src/ast-value-factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/bootstrapper.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M src/code.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/code-stubs.h View 1 2 3 4 chunks +16 lines, -3 lines 0 comments Download
M src/compiler.cc View 1 2 3 4 5 6 7 8 9 1 chunk +6 lines, -1 line 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/linkage.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/deoptimizer.cc View 1 2 3 4 5 6 7 8 3 chunks +5 lines, -3 lines 0 comments Download
M src/factory.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/frames.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/full-codegen.cc View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M src/globals.h View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 1 2 3 4 5 6 7 8 2 chunks +7 lines, -1 line 0 comments Download
M src/hydrogen-instructions.h View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 5 chunks +18 lines, -3 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 3 4 5 6 7 8 4 chunks +18 lines, -4 lines 0 comments Download
M src/ic/ic.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M src/objects.h View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
M src/objects-inl.h View 1 2 3 4 chunks +5 lines, -6 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-function.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 2 3 4 5 6 3 chunks +17 lines, -4 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/scopes.h View 1 2 3 4 5 6 7 8 3 chunks +7 lines, -2 lines 0 comments Download
M src/scopes.cc View 1 2 3 4 5 6 7 8 4 chunks +18 lines, -14 lines 0 comments Download
M src/variables.h View 2 chunks +2 lines, -5 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 4 5 6 7 8 9 5 chunks +16 lines, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 3 4 5 6 7 8 5 chunks +20 lines, -3 lines 0 comments Download
M test/mjsunit/harmony/classes-experimental.js View 1 2 3 4 5 6 7 8 1 chunk +206 lines, -46 lines 0 comments Download

Messages

Total messages: 18 (3 generated)
Dmitry Lomov (no reviews)
PTAL before platform ports. The idea is: subclass constructors (the ones that have 'extends') have ...
5 years, 10 months ago (2015-02-09 16:31:44 UTC) #1
arv (Not doing code reviews)
On 2015/02/09 16:31:44, Dmitry Lomov (chromium) wrote: > PTAL before platform ports. > > The ...
5 years, 10 months ago (2015-02-09 17:24:07 UTC) #2
arv (Not doing code reviews)
I like this approach. But... How is this going to work? new.target needs to work ...
5 years, 10 months ago (2015-02-09 17:44:39 UTC) #3
Dmitry Lomov (no reviews)
Response to comments: On 2015/02/09 17:44:39, arv wrote: > I like this approach. But... > ...
5 years, 10 months ago (2015-02-09 18:28:23 UTC) #4
Dmitry Lomov (no reviews)
PTAL, all platforms done and comments addressed https://codereview.chromium.org/908883002/diff/20001/src/runtime/runtime-object.cc File src/runtime/runtime-object.cc (right): https://codereview.chromium.org/908883002/diff/20001/src/runtime/runtime-object.cc#newcode1304 src/runtime/runtime-object.cc:1304: if (*original_function ...
5 years, 10 months ago (2015-02-10 19:22:15 UTC) #5
arv (Not doing code reviews)
LGTM Mostly just js style nits but also some ideas to improve the tests. https://codereview.chromium.org/908883002/diff/140001/src/arm/full-codegen-arm.cc ...
5 years, 10 months ago (2015-02-10 20:15:19 UTC) #6
Dmitry Lomov (no reviews)
All done, landing https://codereview.chromium.org/908883002/diff/140001/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): https://codereview.chromium.org/908883002/diff/140001/src/arm/full-codegen-arm.cc#newcode266 src/arm/full-codegen-arm.cc:266: IsSubclassConstructor(info->function()->kind()) On 2015/02/10 20:15:18, arv wrote: ...
5 years, 10 months ago (2015-02-11 00:58:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/908883002/150001
5 years, 10 months ago (2015-02-11 00:59:12 UTC) #10
commit-bot: I haz the power
Committed patchset #9 (id:150001)
5 years, 10 months ago (2015-02-11 01:23:11 UTC) #11
commit-bot: I haz the power
Patchset 9 (id:??) landed as https://crrev.com/8aed43e82c6d2742fe5988603cb8841324cc942b Cr-Commit-Position: refs/heads/master@{#26560}
5 years, 10 months ago (2015-02-11 01:23:23 UTC) #12
Dmitry Lomov (no reviews)
A revert of this CL (patchset #9 id:150001) has been created in https://codereview.chromium.org/911363002/ by dslomov@chromium.org. ...
5 years, 10 months ago (2015-02-11 01:35:39 UTC) #13
Dmitry Lomov (no reviews)
x64 issue fixed + rebased; landing
5 years, 10 months ago (2015-02-11 09:24:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/908883002/170001
5 years, 10 months ago (2015-02-11 09:25:51 UTC) #16
commit-bot: I haz the power
Committed patchset #10 (id:170001)
5 years, 10 months ago (2015-02-11 09:47:38 UTC) #17
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 09:47:57 UTC) #18
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/bf49be39f333bf1ce14202663595d455aa4b24cb
Cr-Commit-Position: refs/heads/master@{#26572}

Powered by Google App Engine
This is Rietveld 408576698