dart2js cps: Handle optional parameters in builder.

pkg/compiler/lib/src/universe/universe.dart

Index: pkg/compiler/lib/src/universe/universe.dart
diff --git a/pkg/compiler/lib/src/universe/universe.dart b/pkg/compiler/lib/src/universe/universe.dart
index a7ddbb03bd91dbda5eafd2af2d45e2c0c780f12d..0b8a40896ac3b4c8e459dc01c42445a6a5840b98 100644
--- a/pkg/compiler/lib/src/universe/universe.dart
+++ b/pkg/compiler/lib/src/universe/universe.dart
@@ -593,6 +593,21 @@ class Selector {
     return result;
   }
 
+  /// Returns a copy of [compiledArguments] where named arguments occur in
+  /// normalized order.
+  List makeDynamicArgumentsList(List compiledArguments) {

[karlklose, 2015/02/10 09:07:45]

I am not happy with having this helper here. Could we move it to the builder (or
is it used elsewhere?).

Please also add type arguments to the list annotation and constant.

[asgerf, 2015/02/10 09:37:18]

I agree.

I put it here because makeArgumentsList and makeArgumentsList2 are also here,
and it seemed inconsistent to have one and not the other in here. (Expand the
above 90 lines to see them.)

As with makeArgumentsList, we can't properly annotate List because the method is
generic. I didn't like the comment-style annotations used above.

It turns out one version of makeArgumentsList is only used in the CPS builder,
while the other is used from a couple of different places all tied to the SSA
builder. 

I've moved makeArgumentsList and makeDynamicArgumentsList into the CPS builder
and renamed makeArgumentsList2 -> makeArgumentsList for use by the SSA builder.

+    assert(compiledArguments.length == argumentCount);
+    List result = [];
+    for (int i=0; i<positionalArgumentCount; i++) {

[karlklose, 2015/02/10 09:07:45]

Space around binary operators.

[asgerf, 2015/02/10 09:37:18]

Done.

+      result.add(compiledArguments[i]);
+    }
+    for (String argName in getOrderedNamedArguments()) {
+      int nameIndex = namedArguments.indexOf(argName);
+      int translatedIndex = positionalArgumentCount + nameIndex;
+      result.add(compiledArguments[translatedIndex]);
+    }
+    return result;
+  }
 
   /**
    * Fills [list] with the arguments in the order expected by