dart2js cps: Handle optional parameters in builder.

pkg/compiler/lib/src/universe/universe.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library universe;
 
 import '../elements/elements.dart';
 import '../dart2jslib.dart';
 import '../dart_types.dart';
 import '../types/types.dart';
@@ skipping 575 matching lines @@
         if (foundIndex != -1) {
           result.add(compiledNamedArguments[foundIndex]);
         } else {
           result.add(compileDefaultValue(element));
         }
       });
     }
     return result;
   }
 
+  /// Returns a copy of [compiledArguments] where named arguments occur in
+  /// normalized order.
+  List makeDynamicArgumentsList(List compiledArguments) {

[karlklose, 2015/02/10 09:07:45]

I am not happy with having this helper here. Could we move it to the builder (or
is it used elsewhere?).

Please also add type arguments to the list annotation and constant.

[asgerf, 2015/02/10 09:37:18]

I agree.

I put it here because makeArgumentsList and makeArgumentsList2 are also here,
and it seemed inconsistent to have one and not the other in here. (Expand the
above 90 lines to see them.)

As with makeArgumentsList, we can't properly annotate List because the method is
generic. I didn't like the comment-style annotations used above.

It turns out one version of makeArgumentsList is only used in the CPS builder,
while the other is used from a couple of different places all tied to the SSA
builder. 

I've moved makeArgumentsList and makeDynamicArgumentsList into the CPS builder
and renamed makeArgumentsList2 -> makeArgumentsList for use by the SSA builder.

+    assert(compiledArguments.length == argumentCount);
+    List result = [];
+    for (int i=0; i<positionalArgumentCount; i++) {

[karlklose, 2015/02/10 09:07:45]

Space around binary operators.

[asgerf, 2015/02/10 09:37:18]

Done.

+      result.add(compiledArguments[i]);
+    }
+    for (String argName in getOrderedNamedArguments()) {
+      int nameIndex = namedArguments.indexOf(argName);
+      int translatedIndex = positionalArgumentCount + nameIndex;
+      result.add(compiledArguments[translatedIndex]);
+    }
+    return result;
+  }
 
   /**
    * Fills [list] with the arguments in the order expected by
    * [callee], and where [caller] is a synthesized element
    *
    * [compileArgument] is a function that returns a compiled version
    * of a parameter of [callee].
    *
    * [compileConstant] is a function that returns a compiled constant
    * of an optional argument that is not in the parameters of [callee].
@@ skipping 236 matching lines @@
 
   Selector extendIfReachesAll(Compiler compiler) {
     bool canReachAll = compiler.enabledInvokeOn
         && mask.needsNoSuchMethodHandling(this, compiler.world);
     return canReachAll
         ? new TypedSelector(
             compiler.typesTask.dynamicType, this, compiler.world)
         : this;
   }
 }