Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 908853004: Revert of Reland #2: Ensure WebView notifies desktop automation on creation, destruction, and change Original (Closed)

Created:
5 years, 10 months ago by David Tseng
Modified:
5 years, 10 months ago
Reviewers:
tfarina, dmazzoni
CC:
chromium-reviews, extensions-reviews_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland #2: Ensure WebView notifies desktop automation on creation, destruction, and change Original (patchset #7 id:120001 of https://codereview.chromium.org/890013006/) Reason for revert: Cause of flakes in chromevox_tests BackgroundTest.* Original issue's description: > Reland #2: Ensure WebView notifies desktop automation on creation, destruction, and change > > Original issue: https://codereview.chromium.org/880063002 > Previous reland attempt: https://codereview.chromium.org/895623003/ > > This cl changes the way in which ChromeVox initially verbalizes a page which led to flakeyness in > chromevox_tests --gtest_filter=BackgroundTest.* > > To attempt and address the flakeyness, > - chromevox_e2e_test_base.js and chromevox_next_e2e_test_base.js now explicitly separates listening to page load events from the chrome.automation tree and the chrome.tabs APIs. > They are named: runWithLoadedTree, runWithLoadedTab, and runWithTab. The last method allows a caller to create a tab, but not wait for it to load (based on the tab status being 'complete'). > - each test in background_test now no longer waits for ChromeVox to speak 'start' (which formerly could have been triggered by a loadComplete automation event). > - tab creation is still done via the tabs API, but listening for load is done via chrome.automation. (i.e. add a listener for an automation tree to load completely, then create a tab). > > It is not known at this time if this cl will continue to cause flakes in the above tests. Try bots and local runs yielded no flakeyness. The next step may be to introduce logging to identify the source of the flakeyness. > > TBR=tfarina > > Committed: https://crrev.com/9b006b56ca402da3774708f08e062c89018d57a6 > Cr-Commit-Position: refs/heads/master@{#315362} TBR=dmazzoni@chromium.org,tfarina@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -158 lines) Patch
M chrome/browser/resources/chromeos/chromevox/common/chrome_extension_externs.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/editable_text_base.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js View 3 chunks +0 lines, -21 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 5 chunks +52 lines, -33 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs View 4 chunks +15 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs View 2 chunks +20 lines, -19 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js View 2 chunks +9 lines, -18 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js View 1 chunk +5 lines, -14 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/testing/mock_tts.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/automation/automation_node.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/extension_js_browser_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/extension_load_waiter_one_shot.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/views/accessibility/ax_aura_obj_cache.h View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/views/accessibility/ax_aura_obj_cache.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/accessibility/ax_widget_obj_wrapper.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ui/views/controls/webview/webview.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/webview/webview.cc View 7 chunks +12 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (5 generated)
David Tseng
5 years, 10 months ago (2015-02-09 21:22:14 UTC) #1
Created Revert of Reland #2: Ensure WebView notifies desktop automation on
creation, destruction, and change  Original

Powered by Google App Engine
This is Rietveld 408576698