chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js - Issue 908853004: Revert of Reland #2: Ensure WebView notifies desktop automation on creation, destruction, and change Original

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js

Issue 908853004: Revert of Reland #2: Ensure WebView notifies desktop automation on creation, destruction, and change Original (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs ('k') | chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js

diff --git a/chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js b/chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js

index a14c753d84413f589b1384d2449d467414bd123f..1edf3167bd8121ddaa27520ce6ed1162fa3bfde1 100644

--- a/chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js

+++ b/chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js

@@ -58,26 +58,11 @@

/**

- * Launch a new tab, wait until tab status complete, then run callback.

+ * Run a test with the specified HTML snippet loaded.

* @param {function() : void} doc Snippet wrapped inside of a function.

* @param {function()} callback Called once the document is ready.

- runWithLoadedTab: function(doc, callback) {

- this.launchNewTabWithDoc(doc, function(tab) {

- chrome.tabs.onUpdated.addListener(function(tabId, changeInfo) {

- if (tabId == tab.id && changeInfo.status == 'complete') {

- callback(tabId);

- }

- });

- },

- /**

- * Launches the given document in a new tab.

- * @param {function() : void} doc Snippet wrapped inside of a function.

- * @param {function()} opt_callback Called once the document is created.

- */

- runWithTab: function(doc, opt_callback) {

+ runWithDocument: function(doc, callback) {

var docString = TestUtils.extractHtmlFromCommentEncodedString(doc);

var url = 'data:text/html,<!doctype html>' +

docString +

@@ -86,7 +71,13 @@

active: true,

url: url

};

- chrome.tabs.create(createParams, opt_callback);

+ chrome.tabs.create(createParams, function(tab) {

+ chrome.tabs.onUpdated.addListener(function(tabId, changeInfo) {

+ if (tabId == tab.id && changeInfo.status == 'complete') {

+ callback(tabId);

+ }

+ });

/**