Move some file api files to fileapi folder

Move some file api files to fileapi folder

File file_stream_reader and local_file_stream_reader was in
storage/browser/blob, move them to storage/browser/fileapi, make it
more understandable.

BUG=456634
Committed: https://crrev.com/996d331659456cfd796506a542e741697ec50400
Cr-Commit-Position: refs/heads/master@{#317978}

[zhuoyu.qian, 2015-02-09 05:45:08]

zhuoyu.qian@samsung.com changed reviewers:
+ darin@chromium.org, mtomasz@chromium.org, tzik@chromium.org

[zhuoyu.qian, 2015-02-09 05:45:09]

I'd like you to do a code review.  Please visit

    https://codereview.chromium.org/908833002

to have a look.
Thank you.

[mtomasz, 2015-02-09 05:53:04]

On 2015/02/09 05:45:09, zhuoyu.qian wrote:
> I'd like you to do a code review.  Please visit
> 
>     https://codereview.chromium.org/908833002
> 
> to have a look.
> Thank you.

Basically lgtm, but please wait for @tzik confirmation in case there was some
strong historical reason why these classes were in that directory.

[tzik, 2015-02-09 06:31:28]

On 2015/02/09 05:53:04, mtomasz wrote:
> On 2015/02/09 05:45:09, zhuoyu.qian wrote:
> > I'd like you to do a code review.  Please visit
> > 
> >     https://codereview.chromium.org/908833002
> > 
> > to have a look.
> > Thank you.
> 
> Basically lgtm, but please wait for @tzik confirmation in case there was some
> strong historical reason why these classes were in that directory.

Looks good. AFAIK, there's no strong reason to put it blob/ other than a
historical reason:
That origin was FileReader that backs web-facing FileReader API to read a blob.

BTW, did you complete a Contributor License Agreement in
http://www.chromium.org/developers/contributing-code before?

[zhuoyu.qian, 2015-02-09 06:37:59]

On 2015/02/09 06:31:28, tzik wrote:
> On 2015/02/09 05:53:04, mtomasz wrote:
> > On 2015/02/09 05:45:09, zhuoyu.qian wrote:
> > > I'd like you to do a code review.  Please visit
> > > 
> > >     https://codereview.chromium.org/908833002
> > > 
> > > to have a look.
> > > Thank you.
> > 
> > Basically lgtm, but please wait for @tzik confirmation in case there was
some
> > strong historical reason why these classes were in that directory.
> 
> Looks good. AFAIK, there's no strong reason to put it blob/ other than a
> historical reason:
> That origin was FileReader that backs web-facing FileReader API to read a
blob.
> 
> BTW, did you complete a Contributor License Agreement in
> http://www.chromium.org/developers/contributing-code before?

Yes, I did complete the CLA.

[tzik, 2015-02-09 06:50:20]

On 2015/02/09 06:37:59, zhuoyu.qian wrote:
> On 2015/02/09 06:31:28, tzik wrote:
> > On 2015/02/09 05:53:04, mtomasz wrote:
> > > On 2015/02/09 05:45:09, zhuoyu.qian wrote:
> > > > I'd like you to do a code review.  Please visit
> > > > 
> > > >     https://codereview.chromium.org/908833002
> > > > 
> > > > to have a look.
> > > > Thank you.
> > > 
> > > Basically lgtm, but please wait for @tzik confirmation in case there was
> some
> > > strong historical reason why these classes were in that directory.
> > 
> > Looks good. AFAIK, there's no strong reason to put it blob/ other than a
> > historical reason:
> > That origin was FileReader that backs web-facing FileReader API to read a
> blob.
> > 
> > BTW, did you complete a Contributor License Agreement in
> > http://www.chromium.org/developers/contributing-code before?
> 
> Yes, I did complete the CLA.

Fine, so please add yourself into the AUTHORS file in this CL.

[zhuoyu.qian, 2015-02-09 06:58:20]

New patchsets have been uploaded after l-g-t-m from mtomasz@chromium.org

[zhuoyu.qian, 2015-02-09 06:59:37]

On 2015/02/09 06:50:20, tzik wrote:
> On 2015/02/09 06:37:59, zhuoyu.qian wrote:
> > On 2015/02/09 06:31:28, tzik wrote:
> > > On 2015/02/09 05:53:04, mtomasz wrote:
> > > > On 2015/02/09 05:45:09, zhuoyu.qian wrote:
> > > > > I'd like you to do a code review.  Please visit
> > > > > 
> > > > >     https://codereview.chromium.org/908833002
> > > > > 
> > > > > to have a look.
> > > > > Thank you.
> > > > 
> > > > Basically lgtm, but please wait for @tzik confirmation in case there was
> > some
> > > > strong historical reason why these classes were in that directory.
> > > 
> > > Looks good. AFAIK, there's no strong reason to put it blob/ other than a
> > > historical reason:
> > > That origin was FileReader that backs web-facing FileReader API to read a
> > blob.
> > > 
> > > BTW, did you complete a Contributor License Agreement in
> > > http://www.chromium.org/developers/contributing-code before?
> > 
> > Yes, I did complete the CLA.
> 
> Fine, so please add yourself into the AUTHORS file in this CL.

Done.

[tzik, 2015-02-09 07:57:43]

lgtm

[zhuoyu.qian, 2015-02-09 09:46:38]

The CQ bit was checked by zhuoyu.qian@samsung.com

[commit-bot: I haz the power, 2015-02-09 09:47:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/908833002/20001

[commit-bot: I haz the power, 2015-02-09 09:52:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-09 09:52:44]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[zhuoyu.qian, 2015-02-09 10:15:17]

zhuoyu.qian@samsung.com changed reviewers:
+ kinuko+fileapi@chromium.org, kinuko@chromium.org

[zhuoyu.qian, 2015-02-09 10:15:18]

I'd like you to do a code review.  Please visit

    https://codereview.chromium.org/908833002

to have a look.
Thank you.

[mtomasz, 2015-02-11 07:24:08]

On 2015/02/09 10:15:18, zhuoyu.qian wrote:
> I'd like you to do a code review.  Please visit
> 
>     https://codereview.chromium.org/908833002
> 
> to have a look.
> Thank you.

zhuoyu.qian: For large patches like this, it's useful to ask reviewers to look
at specific files they are responsible of. Eg. most of files should be already
covered by tzik and me. The "git cl owners" command may be helpful.

[zhuoyu.qian, 2015-02-11 08:19:29]

On 2015/02/11 07:24:08, mtomasz wrote:
> On 2015/02/09 10:15:18, zhuoyu.qian wrote:
> > I'd like you to do a code review.  Please visit
> > 
> >     https://codereview.chromium.org/908833002
> > 
> > to have a look.
> > Thank you.
> 
> zhuoyu.qian: For large patches like this, it's useful to ask reviewers to look
> at specific files they are responsible of. Eg. most of files should be already
> covered by tzik and me. The "git cl owners" command may be helpful.

Yes, now I find there are nine files are missing L-G-T-M from an OWNER,
    chrome/browser/drive/drive_api_util.cc
    content/public/test/test_file_system_backend.cc
    storage/browser/BUILD.gn
    storage/browser/blob/blob_url_request_job.cc
    storage/browser/blob/file_stream_reader.cc
    storage/browser/blob/file_stream_reader.h
    storage/browser/blob/local_file_stream_reader.cc
    storage/browser/blob/local_file_stream_reader.h
    storage/storage_browser.gyp
So I add kinuko and darin as reviewers, who are the owners of these files.
I am waiting for their comment here now.

[kinuko, 2015-02-12 06:40:31]

>     storage/browser/BUILD.gn
>     storage/browser/blob/blob_url_request_job.cc
>     storage/browser/blob/file_stream_reader.cc
>     storage/browser/blob/file_stream_reader.h
>     storage/browser/blob/local_file_stream_reader.cc
>     storage/browser/blob/local_file_stream_reader.h
>     storage/storage_browser.gyp

lgtm for storage bits

>     chrome/browser/drive/drive_api_util.cc
>     content/public/test/test_file_system_backend.cc

Fwiw, for a simple change like this usually it works faster to ask per-directory
reviewers (i.e. pick owners from content/public/test/OWNERS and
chrome/browser/drive/OWNERS respectively) rather than asking a uber reviewer to
do a gigantic code review.

[zhuoyu.qian, 2015-02-12 06:51:31]

On 2015/02/12 06:40:31, kinuko wrote:
> >     storage/browser/BUILD.gn
> >     storage/browser/blob/blob_url_request_job.cc
> >     storage/browser/blob/file_stream_reader.cc
> >     storage/browser/blob/file_stream_reader.h
> >     storage/browser/blob/local_file_stream_reader.cc
> >     storage/browser/blob/local_file_stream_reader.h
> >     storage/storage_browser.gyp
> 
> lgtm for storage bits
> 
> >     chrome/browser/drive/drive_api_util.cc
> >     content/public/test/test_file_system_backend.cc
> 
> Fwiw, for a simple change like this usually it works faster to ask
per-directory
> reviewers (i.e. pick owners from content/public/test/OWNERS and
> chrome/browser/drive/OWNERS respectively) rather than asking a uber reviewer
to
> do a gigantic code review.

OK, Thank you for your advice!

[zhuoyu.qian, 2015-02-12 06:57:08]

zhuoyu.qian@samsung.com changed reviewers:
+ sky@chromium.org, yoshiki@chromium.org

[zhuoyu.qian, 2015-02-12 06:57:09]

Hi, yoshiki and sky,
I'd like you to do a code review.  Please visit

    https://codereview.chromium.org/908833002

to have a look.
Thank you.

[yoshiki, 2015-02-12 07:10:02]

chrome/browser/drive/drive_api_util.cc lgtm.

[kinuko, 2015-02-12 11:04:00]

On 2015/02/12 06:57:09, zhuoyu.qian wrote:
> Hi, yoshiki and sky,
> I'd like you to do a code review.  Please visit
> 
>     https://codereview.chromium.org/908833002
> 
> to have a look.
> Thank you.

A few more tips:
- no need to write the CL link in the message, it's automatically included in
the email
- list up directory names in the message would help reviewers find which files
to review, e.g. "sky: I'd like you to do a code review for content/public/test/"

HTH

[zhuoyu.qian, 2015-02-13 01:48:26]

Hi sky: I'd like you to do a code review for
content/public/test/test_file_system_backend.cc

[zhuoyu.qian, 2015-02-16 01:47:58]

zhuoyu.qian@samsung.com changed reviewers:
+ jcivelli@chromium.org

[zhuoyu.qian, 2015-02-16 01:47:59]

Hi Jay:
I'd like you to do a code review for
content/public/test/test_file_system_backend.cc

[Jay Civelli, 2015-02-17 16:29:24]

LGTM for content/public/test

[mtomasz, 2015-02-20 00:10:21]

On 2015/02/17 16:29:24, Jay Civelli wrote:
> LGTM for content/public/test

zhuoyu.qian: Can we commit?

[zhuoyu.qian, 2015-02-25 00:41:02]

The CQ bit was checked by zhuoyu.qian@samsung.com

[commit-bot: I haz the power, 2015-02-25 00:42:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/908833002/20001

[zhuoyu.qian, 2015-02-25 01:19:29]

On 2015/02/20 00:10:21, mtomasz wrote:
> On 2015/02/17 16:29:24, Jay Civelli wrote:
> > LGTM for content/public/test
> 
> zhuoyu.qian: Can we commit?

Yes, please commit it. Thank you.

[commit-bot: I haz the power, 2015-02-25 01:19:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-25 01:19:57]

Try jobs failed on following builders:
  android_rel_tests_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tes...)

[zhuoyu.qian, 2015-02-25 01:24:20]

On 2015/02/20 00:10:21, mtomasz wrote:
> On 2015/02/17 16:29:24, Jay Civelli wrote:
> > LGTM for content/public/test
> 
> zhuoyu.qian: Can we commit?

mtomasz: I check the commit button, but some try jobs failed. 
Is there any step I missed?
Thank you.

[mtomasz, 2015-02-25 01:26:56]

On 2015/02/25 01:24:20, zhuoyu.qian wrote:
> On 2015/02/20 00:10:21, mtomasz wrote:
> > On 2015/02/17 16:29:24, Jay Civelli wrote:
> > > LGTM for content/public/test
> > 
> > zhuoyu.qian: Can we commit?
> 
> mtomasz: I check the commit button, but some try jobs failed. 
> Is there any step I missed?
> Thank you.

Some of the base files have changed and there are merge conflicts. Please rebase
and upload a new patchset, then click the commit checkbox again. Let me know if
you need any assistance. Cheers.

[zhuoyu.qian, 2015-02-25 02:28:16]

The CQ bit was checked by zhuoyu.qian@samsung.com

[zhuoyu.qian, 2015-02-25 02:28:17]

The patchset sent to the CQ was uploaded after l-g-t-m from tzik@chromium.org,
kinuko@chromium.org, mtomasz@chromium.org, jcivelli@chromium.org,
yoshiki@chromium.org
Link to the patchset: https://codereview.chromium.org/908833002/#ps40001 (title:
"rebase")

[commit-bot: I haz the power, 2015-02-25 02:28:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/908833002/40001

[commit-bot: I haz the power, 2015-02-25 05:01:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-25 05:02:15]

Patchset 3 (id:??) landed as
https://crrev.com/996d331659456cfd796506a542e741697ec50400
Cr-Commit-Position: refs/heads/master@{#317978}