Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 908703002: Revert of Removing silence trimming from WebRTC quality test. (Closed)

Created:
5 years, 10 months ago by phoglund_chromium
Modified:
5 years, 10 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Removing silence trimming from WebRTC quality test. (patchset #5 id:80001 of https://codereview.chromium.org/890893004/) Reason for revert: This actually made the score worse by about 0.4 on all bots except one, and one bot is still not helped by this. I will try to solve this through other means, like forcing the volume to the right level on the bots where we get bad scores. Original issue's description: > Removing silence trimming from WebRTC quality test > > It turns out PESQ can deal with delays, so we don't need to > silence-trim the files to get them to line up. This solves another > problem where the silence-trimming becomes too aggressive on Windows > with the new ref file. > > I also need to monitor if the new ref file, which is a lot lower > in volume than the old one, unfairly punishes the score. The > speaker volume is a bit random on the bots so the recording could > end up being quite low. Tests on my workstation suggests that PESQ > is actually pretty good about ignoring that too though. There will > be a slight effect on the score (like 0.4 MOS), which I think is > acceptable. Otherwise we need to find a way to control the speaker > volume on the bots much more stringently. > > BUG=446859 > > Committed: https://crrev.com/36d358e0cdff201a99501e9c986a8a26f8965a40 > Cr-Commit-Position: refs/heads/master@{#314797} TBR=henrika@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=446859 Committed: https://crrev.com/218b32ccfa3202d84c8f17f6fb3420c4769cb88a Cr-Commit-Position: refs/heads/master@{#315192}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -16 lines) Patch
M chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc View 10 chunks +19 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
phoglund_chromium
Created Revert of Removing silence trimming from WebRTC quality test.
5 years, 10 months ago (2015-02-07 12:22:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/908703002/1
5 years, 10 months ago (2015-02-07 12:22:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-07 12:23:14 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-07 12:23:54 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/218b32ccfa3202d84c8f17f6fb3420c4769cb88a
Cr-Commit-Position: refs/heads/master@{#315192}

Powered by Google App Engine
This is Rietveld 408576698