Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 890893004: Removing silence trimming from WebRTC quality test. (Closed)

Created:
5 years, 10 months ago by phoglund_chromium
Modified:
5 years, 10 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing silence trimming from WebRTC quality test It turns out PESQ can deal with delays, so we don't need to silence-trim the files to get them to line up. This solves another problem where the silence-trimming becomes too aggressive on Windows with the new ref file. I also need to monitor if the new ref file, which is a lot lower in volume than the old one, unfairly punishes the score. The speaker volume is a bit random on the bots so the recording could end up being quite low. Tests on my workstation suggests that PESQ is actually pretty good about ignoring that too though. There will be a slight effect on the score (like 0.4 MOS), which I think is acceptable. Otherwise we need to find a way to control the speaker volume on the bots much more stringently. BUG=446859 Committed: https://crrev.com/36d358e0cdff201a99501e9c986a8a26f8965a40 Cr-Commit-Position: refs/heads/master@{#314797}

Patch Set 1 #

Patch Set 2 : Reverting change to force_mic_volume_max; appears pesq deals with level differences #

Patch Set 3 : Reverting some old changes #

Patch Set 4 : #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -19 lines) Patch
M chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc View 1 2 3 10 chunks +16 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
phoglund_chromium
ping :)
5 years, 10 months ago (2015-02-04 15:09:22 UTC) #2
henrika (OOO until Aug 14)
LGTM
5 years, 10 months ago (2015-02-04 15:24:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890893004/80001
5 years, 10 months ago (2015-02-05 12:05:08 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-02-05 13:57:03 UTC) #7
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/36d358e0cdff201a99501e9c986a8a26f8965a40 Cr-Commit-Position: refs/heads/master@{#314797}
5 years, 10 months ago (2015-02-05 13:58:04 UTC) #8
phoglund_chromium
5 years, 10 months ago (2015-02-07 12:22:21 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/908703002/ by phoglund@chromium.org.

The reason for reverting is: This actually made the score worse by about 0.4 on
all bots except one, and one bot is still not helped by this. I will try to
solve this through other means, like forcing the volume to the right level on
the bots where we get bad scores..

Powered by Google App Engine
This is Rietveld 408576698