Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

Issue 908493003: filter static methods when showing instance completions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart b/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart
index ba6c396fcaf221b48ea77ed1ecfe5fef0f8c6dbc..f951371e8f281e33ee1217315eda96ebd9191eb7 100644
--- a/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart
+++ b/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart
@@ -321,16 +321,21 @@ class InterfaceTypeSuggestionBuilder {
// exceptions to handle getter/setter pairs).
for (InterfaceType targetType in _getTypeOrdering(type)) {
for (MethodElement method in targetType.methods) {
- addSuggestion(method);
+ // Exclude static methods when completion on an instance
+ if (!method.isStatic) {
+ addSuggestion(method);
+ }
}
for (PropertyAccessorElement propertyAccessor in targetType.accessors) {
- if (propertyAccessor.isSynthetic) {
- // Avoid visiting a field twice
- if (propertyAccessor.isGetter) {
- addSuggestion(propertyAccessor.variable);
+ if (!propertyAccessor.isStatic) {
+ if (propertyAccessor.isSynthetic) {
+ // Avoid visiting a field twice
+ if (propertyAccessor.isGetter) {
+ addSuggestion(propertyAccessor.variable);
+ }
+ } else {
+ addSuggestion(propertyAccessor);
}
- } else {
- addSuggestion(propertyAccessor);
}
}
}

Powered by Google App Engine
This is Rietveld 408576698