filter static methods when showing instance completions

pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.suggestion.builder;
 
 import 'dart:async';
 import 'dart:collection';
 
 import 'package:analysis_server/src/protocol_server.dart' as protocol;
@@ skipping 303 matching lines @@
     }
   }
 
   void _buildSuggestions(InterfaceType type, LibraryElement library) {
     // Visit all of the types in the class hierarchy, collecting possible
     // completions.  If multiple elements are found that complete to the same
     // identifier, addSuggestion will discard all but the first (with a few
     // exceptions to handle getter/setter pairs).
     for (InterfaceType targetType in _getTypeOrdering(type)) {
       for (MethodElement method in targetType.methods) {
-        addSuggestion(method);
+        // Exclude static methods when completion on an instance
+        if (!method.isStatic) {
+          addSuggestion(method);
+        }
       }
       for (PropertyAccessorElement propertyAccessor in targetType.accessors) {
-        if (propertyAccessor.isSynthetic) {
-          // Avoid visiting a field twice
-          if (propertyAccessor.isGetter) {
-            addSuggestion(propertyAccessor.variable);
+        if (!propertyAccessor.isStatic) {
+          if (propertyAccessor.isSynthetic) {
+            // Avoid visiting a field twice
+            if (propertyAccessor.isGetter) {
+              addSuggestion(propertyAccessor.variable);
+            }
+          } else {
+            addSuggestion(propertyAccessor);
           }
-        } else {
-          addSuggestion(propertyAccessor);
         }
       }
     }
   }
 
   /**
    * Get a list of [InterfaceType]s that should be searched to find the
    * possible completions for an object having type [type].
    */
   List<InterfaceType> _getTypeOrdering(InterfaceType type) {
@@ skipping 229 matching lines @@
    * or `false` if [computeFull] should be called.
    */
   bool computeFast(AstNode node);
 
   /**
    * Return a future that computes the suggestions given a fully resolved AST.
    * The future returns `true` if suggestions were added, else `false`.
    */
   Future<bool> computeFull(AstNode node);
 }