PPAPI: Make tests that disable the proxy lock re-enable it

PPAPI: Make tests that disable the proxy lock re-enable it

Rather than force all unit tests that rely on the ProxyLock to enable it,
let's make sure that all tests that _disable_ it re-enable it on exit.

BUG=
R=teravest@chromium.org

Committed: https://crrev.com/25ea5b2087b4c31fa42dea9b0de759d4895d0612
Cr-Commit-Position: refs/heads/master@{#315666}

Committed: https://crrev.com/bd96c1e0f3c41f2254600c1285916f52ff29b92c
Cr-Commit-Position: refs/heads/master@{#315895}

[teravest, 2015-02-10 21:26:32]

There are some uncovered cases where DisableLockingOnThreadForTest is called:

https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/p...

https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/p...

This is from codesearch, not sure if there are unindexed uses.

[dmichael (off chromium), 2015-02-10 21:48:24]

git gs just now only found those. Fixed. Nice catch.

[teravest, 2015-02-10 21:51:57]

lgtm

It'd be nice to have something RAII-based for the tests that disable and
re-enable the proxy lock, but this is fine.

[dmichael (off chromium), 2015-02-10 22:22:41]

On 2015/02/10 21:51:57, teravest wrote:
> lgtm
> 
> It'd be nice to have something RAII-based for the tests that disable and
> re-enable the proxy lock, but this is fine.
That'd be cool, but I think wouldn't help in practice since they all happen in
SetUp/TearDown

[dmichael (off chromium), 2015-02-10 22:22:43]

The CQ bit was checked by dmichael@chromium.org

[commit-bot: I haz the power, 2015-02-10 22:23:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/908363002/20001

[commit-bot: I haz the power, 2015-02-10 23:01:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-10 23:02:04]

Patchset 2 (id:??) landed as
https://crrev.com/25ea5b2087b4c31fa42dea9b0de759d4895d0612
Cr-Commit-Position: refs/heads/master@{#315666}

[dmichael (off chromium), 2015-02-11 00:22:36]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/918433002/ by dmichael@chromium.org.

The reason for reverting is: Broke tests on Linux:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2....

[Nico, 2015-02-11 04:37:47]

On 2015/02/11 00:22:36, dmichael wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/918433002/ by mailto:dmichael@chromium.org.
> 
> The reason for reverting is: Broke tests on Linux:
>
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2....

(also broke the same tests on a clang/win bot; not sure if that's interesting.
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang%28dbg%29%20teste...)

[dmichael (off chromium), 2015-02-11 21:44:37]

New patchsets have been uploaded after l-g-t-m from teravest@chromium.org

[dmichael (off chromium), 2015-02-11 22:14:19]

The CQ bit was checked by dmichael@chromium.org

[commit-bot: I haz the power, 2015-02-11 22:14:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/908363002/40001

[commit-bot: I haz the power, 2015-02-11 23:42:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-11 23:42:44]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[dmichael (off chromium), 2015-02-11 23:48:46]

The CQ bit was checked by dmichael@chromium.org

[dmichael (off chromium), 2015-02-11 23:49:28]

The CQ bit was checked by dmichael@chromium.org

[commit-bot: I haz the power, 2015-02-11 23:50:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/908363002/60001

[commit-bot: I haz the power, 2015-02-12 00:58:18]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-12 00:59:08]

Patchset 4 (id:??) landed as
https://crrev.com/bd96c1e0f3c41f2254600c1285916f52ff29b92c
Cr-Commit-Position: refs/heads/master@{#315895}