Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: ppapi/shared_impl/proxy_lock.h

Issue 908363002: PPAPI: Make tests that disable the proxy lock re-enable it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add export Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/proxy/raw_var_data_unittest.cc ('k') | ppapi/shared_impl/proxy_lock.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/shared_impl/proxy_lock.h
diff --git a/ppapi/shared_impl/proxy_lock.h b/ppapi/shared_impl/proxy_lock.h
index 23afc0e5506e5160b575e08735e44413c0ddbdfb..39b653e1a00bccb49217f9b494d4d5a666d5a67d 100644
--- a/ppapi/shared_impl/proxy_lock.h
+++ b/ppapi/shared_impl/proxy_lock.h
@@ -59,12 +59,11 @@ class PPAPI_SHARED_EXPORT ProxyLock {
// We have some unit tests where one thread pretends to be the host and one
// pretends to be the plugin. This allows the lock to do nothing on only one
// thread to support these tests. See TwoWayTest for more information.
- static void DisableLockingOnThreadForTest();
-
- // Enables locking on the current thread. Although locking is enabled by
- // default, unit tests that rely on the lock being enabled should *still*
- // call this, since a previous test may have disabled locking.
- static void EnableLockingOnThreadForTest();
+ class PPAPI_SHARED_EXPORT LockingDisablerForTest {
+ public:
+ LockingDisablerForTest();
+ ~LockingDisablerForTest();
+ };
private:
friend class content::HostGlobals;
« no previous file with comments | « ppapi/proxy/raw_var_data_unittest.cc ('k') | ppapi/shared_impl/proxy_lock.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698