Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 908273002: Fix SkComposeImageFilter's bounds computation and offset handling (Closed)

Created:
5 years, 10 months ago by ajuma
Modified:
5 years, 10 months ago
Reviewers:
senorblanco, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix SkComposeImageFilter's bounds computation and offset handling This makes SkComposeImageFilter::computeFastBounds compose its filters' bounds (rather than falling back to SkImageFilter::computeFastBounds, which takes the union of the bounds). This also makes SkComposeImageFilter::onFilterImage correctly handle an offset produced when applying the inner filter; such offsets were previously ignored. BUG=chromium:453924 Committed: https://skia.googlesource.com/skia/+/5788faaa2ac4203827c68006b669e277d441e2e4

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add curly braces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -2 lines) Patch
M include/effects/SkComposeImageFilter.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/SkComposeImageFilter.cpp View 1 2 chunks +23 lines, -2 lines 0 comments Download
M tests/ImageFilterTest.cpp View 3 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ajuma
There were the bugs I was referring to in the Slimming Paint meeting yesterday.
5 years, 10 months ago (2015-02-10 20:27:22 UTC) #2
reed1
seems fine, adding senor https://codereview.chromium.org/908273002/diff/1/src/effects/SkComposeImageFilter.cpp File src/effects/SkComposeImageFilter.cpp (right): https://codereview.chromium.org/908273002/diff/1/src/effects/SkComposeImageFilter.cpp#newcode42 src/effects/SkComposeImageFilter.cpp:42: if (!outer->filterImage(proxy, tmp, outerContext, result, ...
5 years, 10 months ago (2015-02-12 21:01:19 UTC) #4
ajuma
https://codereview.chromium.org/908273002/diff/1/src/effects/SkComposeImageFilter.cpp File src/effects/SkComposeImageFilter.cpp (right): https://codereview.chromium.org/908273002/diff/1/src/effects/SkComposeImageFilter.cpp#newcode42 src/effects/SkComposeImageFilter.cpp:42: if (!outer->filterImage(proxy, tmp, outerContext, result, &outerOffset)) On 2015/02/12 21:01:19, ...
5 years, 10 months ago (2015-02-13 16:02:24 UTC) #5
reed1
lgtm
5 years, 10 months ago (2015-02-13 16:12:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/908273002/20001
5 years, 10 months ago (2015-02-13 16:20:59 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 17:05:51 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5788faaa2ac4203827c68006b669e277d441e2e4

Powered by Google App Engine
This is Rietveld 408576698