Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: include/effects/SkComposeImageFilter.h

Issue 908273002: Fix SkComposeImageFilter's bounds computation and offset handling (Closed) Base URL: https://chromium.googlesource.com/skia.git@master
Patch Set: Add curly braces Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/effects/SkComposeImageFilter.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2013 Google Inc. 2 * Copyright 2013 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef SkComposeImageFilter_DEFINED 8 #ifndef SkComposeImageFilter_DEFINED
9 #define SkComposeImageFilter_DEFINED 9 #define SkComposeImageFilter_DEFINED
10 10
11 #include "SkImageFilter.h" 11 #include "SkImageFilter.h"
12 12
13 class SK_API SkComposeImageFilter : public SkImageFilter { 13 class SK_API SkComposeImageFilter : public SkImageFilter {
14 public: 14 public:
15 virtual ~SkComposeImageFilter(); 15 virtual ~SkComposeImageFilter();
16 16
17 static SkImageFilter* Create(SkImageFilter* outer, SkImageFilter* inner) { 17 static SkImageFilter* Create(SkImageFilter* outer, SkImageFilter* inner) {
18 if (NULL == outer) { 18 if (NULL == outer) {
19 return SkSafeRef(inner); 19 return SkSafeRef(inner);
20 } 20 }
21 if (NULL == inner) { 21 if (NULL == inner) {
22 return SkRef(outer); 22 return SkRef(outer);
23 } 23 }
24 SkImageFilter* inputs[2] = { outer, inner }; 24 SkImageFilter* inputs[2] = { outer, inner };
25 return SkNEW_ARGS(SkComposeImageFilter, (inputs)); 25 return SkNEW_ARGS(SkComposeImageFilter, (inputs));
26 } 26 }
27 void computeFastBounds(const SkRect& src, SkRect* dst) const SK_OVERRIDE;
27 28
28 SK_TO_STRING_OVERRIDE() 29 SK_TO_STRING_OVERRIDE()
29 SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkComposeImageFilter) 30 SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkComposeImageFilter)
30 31
31 protected: 32 protected:
32 explicit SkComposeImageFilter(SkImageFilter* inputs[2]) : INHERITED(2, input s) { 33 explicit SkComposeImageFilter(SkImageFilter* inputs[2]) : INHERITED(2, input s) {
33 SkASSERT(inputs[0]); 34 SkASSERT(inputs[0]);
34 SkASSERT(inputs[1]); 35 SkASSERT(inputs[1]);
35 } 36 }
36 virtual bool onFilterImage(Proxy*, const SkBitmap& src, const Context&, 37 virtual bool onFilterImage(Proxy*, const SkBitmap& src, const Context&,
37 SkBitmap* result, SkIPoint* loc) const SK_OVERRID E; 38 SkBitmap* result, SkIPoint* loc) const SK_OVERRID E;
38 bool onFilterBounds(const SkIRect&, const SkMatrix&, SkIRect*) const SK_OVER RIDE; 39 bool onFilterBounds(const SkIRect&, const SkMatrix&, SkIRect*) const SK_OVER RIDE;
39 40
40 private: 41 private:
41 typedef SkImageFilter INHERITED; 42 typedef SkImageFilter INHERITED;
42 }; 43 };
43 44
44 #endif 45 #endif
OLDNEW
« no previous file with comments | « no previous file | src/effects/SkComposeImageFilter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698