Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 908233002: Merge to XFA: Add JavaScript test for constants in Consts.cpp. (Closed)

Created:
5 years, 10 months ago by Tom Sepez
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Merge to XFA: Add JavaScript test for constants in Consts.cpp. Original Review URL: https://codereview.chromium.org/908023003 TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/29e20e9d9c42122620b488340d4e78dfed6b0d34

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -0 lines) Patch
A testing/resources/javascript/consts.in View 1 chunk +71 lines, -0 lines 0 comments Download
A testing/resources/javascript/consts.pdf View 1 chunk +86 lines, -0 lines 0 comments Download
A testing/resources/javascript/consts_expected.txt View 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Tom Sepez
Committed patchset #1 (id:1) manually as 29e20e9d9c42122620b488340d4e78dfed6b0d34 (presubmit successful).
5 years, 10 months ago (2015-02-10 17:10:16 UTC) #1
Lei Zhang
5 years, 10 months ago (2015-02-10 19:59:19 UTC) #2
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698