Issue 908023003: Add JavaScript test for constants in Consts.cpp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 908023003: Add JavaScript test for constants in Consts.cpp. (Closed)

Created:
5 years, 10 months ago by Tom Sepez

Modified:
5 years, 10 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+219 lines, -0 lines)			Patch
A	testing/resources/javascript/consts.in	View	1	1 chunk	+71 lines, -0 lines	0 comments	Download
A	testing/resources/javascript/consts.pdf	View	1	1 chunk	+86 lines, -0 lines	0 comments	Download
A	testing/resources/javascript/consts_expected.txt	View		1 chunk	+62 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

Lei, please review. I'd like to cover these APIs since then we can refactor JS_Define.h, ...

5 years, 10 months ago (2015-02-09 22:56:48 UTC) #2

Tom Sepez

5 years, 10 months ago (2015-02-10 17:04:32 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
994bffe804eb3e2b5af11d0526b278078ab5efcb (presubmit successful).