DescriptionRevert of Issue FrameDestructionObserver::frameDestroyed() notification on detach. (patchset #5 id:80001 of https://codereview.chromium.org/881683003/)
Reason for revert:
Linux ChromiumOS Tests (dbg) bot is timing out on ScreenOrientationBrowserTest.CrashTest_UseAfterDetach,
http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/6186
Can't reproduce locally, but will revert & look into it tomorrow.
Original issue's description:
> Issue FrameDestructionObserver::frameDestroyed() notification on detach.
>
> Send this notification during detach instead of waiting until finalization,
> which will typically proceed shortly afterwards (non-Oilpan.) The
> supplements of the LocalFrame are cleared at the same time so as to
> prevent FrameDestructionObservers that are also supplements from being
> used in their detached state.
>
> Doing so makes the observable lifetimes for FrameDestructionObserver's
> frame() identical, with and without Oilpan. Not having GC/finalization
> of frames be observable to scripts is preferable.
>
> For LocalDOMWindow, a FrameDestructionObserver, its set of registered
> DOMWindowProperty objects are also detached on frameDestroyed(),
> clearing their frame references at the same time.
>
> R=haraken,dcheng
> BUG=446452
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189837
TBR=dcheng@chromium.org,haraken@chromium.org,japhet@chromium.org,oilpan-reviews@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=446452
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189845
Patch Set 1 #
Created: 5 years, 10 months ago
(Patch set is too large to download)
Messages
Total messages: 6 (0 generated)
|