Source/core/frame/DOMWindowProperty.h - Issue 908043002: Revert of Issue FrameDestructionObserver::frameDestroyed() notification on detach.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/DOMWindowProperty.h

Issue 908043002: Revert of Issue FrameDestructionObserver::frameDestroyed() notification on detach. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt ('k') | Source/core/frame/FrameDestructionObserver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/frame/DOMWindowProperty.h

diff --git a/Source/core/frame/DOMWindowProperty.h b/Source/core/frame/DOMWindowProperty.h

index 43833bdadb059d98c08499a4e471fcefa0beb945..38060a06842ecfc984f53a5cd47352721934bccc 100644

--- a/Source/core/frame/DOMWindowProperty.h

+++ b/Source/core/frame/DOMWindowProperty.h

@@ -49,7 +49,7 @@

virtual ~DOMWindowProperty();

#endif

- RawPtrWillBeMember<LocalFrame> m_frame;

+ RawPtrWillBeWeakMember<LocalFrame> m_frame;

#if !ENABLE(OILPAN)

private: