Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 907853002: X87: Fix assertion in full codegen for holed 'this' (Closed)

Created:
5 years, 10 months ago by chunyang.dai
Modified:
5 years, 10 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Fix assertion in full codegen for holed 'this' port 275e088abec213aa0be3eef748926e4be2c5c79f (r26423) original commit message: BUG= R=weiliang.lin@intel.com Committed: https://chromium.googlesource.com/v8/v8/+/f77e016e593a542a64844deb0042e5c54452488e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/x87/full-codegen-x87.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL. thanks
5 years, 10 months ago (2015-02-09 09:36:35 UTC) #2
Weiliang
lgtm
5 years, 10 months ago (2015-02-09 10:23:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/907853002/1
5 years, 10 months ago (2015-02-09 10:24:29 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f77e016e593a542a64844deb0042e5c54452488e Cr-Commit-Position: refs/heads/master@{#26519}
5 years, 10 months ago (2015-02-09 10:25:32 UTC) #6
chunyang.dai
5 years, 10 months ago (2015-02-09 10:25:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f77e016e593a542a64844deb0042e5c54452488e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698