Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: src/x87/full-codegen-x87.cc

Issue 907853002: X87: Fix assertion in full codegen for holed 'this' (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X87 7 #if V8_TARGET_ARCH_X87
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1433 matching lines...) Expand 10 before | Expand all | Expand 10 after
1444 // 1444 //
1445 // The condition on the declaration scopes is a conservative check for 1445 // The condition on the declaration scopes is a conservative check for
1446 // nested functions that access a binding and are called before the 1446 // nested functions that access a binding and are called before the
1447 // binding is initialized: 1447 // binding is initialized:
1448 // function() { f(); let x = 1; function f() { x = 2; } } 1448 // function() { f(); let x = 1; function f() { x = 2; } }
1449 // 1449 //
1450 bool skip_init_check; 1450 bool skip_init_check;
1451 if (var->scope()->DeclarationScope() != scope()->DeclarationScope()) { 1451 if (var->scope()->DeclarationScope() != scope()->DeclarationScope()) {
1452 skip_init_check = false; 1452 skip_init_check = false;
1453 } else if (var->is_this()) { 1453 } else if (var->is_this()) {
1454 CHECK((info_->shared_info()->kind() & kSubclassConstructor) != 0); 1454 CHECK(info_->function() != nullptr &&
1455 (info_->function()->kind() & kSubclassConstructor) != 0);
1455 // TODO(dslomov): implement 'this' hole check elimination. 1456 // TODO(dslomov): implement 'this' hole check elimination.
1456 skip_init_check = false; 1457 skip_init_check = false;
1457 } else { 1458 } else {
1458 // Check that we always have valid source position. 1459 // Check that we always have valid source position.
1459 DCHECK(var->initializer_position() != RelocInfo::kNoPosition); 1460 DCHECK(var->initializer_position() != RelocInfo::kNoPosition);
1460 DCHECK(proxy->position() != RelocInfo::kNoPosition); 1461 DCHECK(proxy->position() != RelocInfo::kNoPosition);
1461 skip_init_check = var->mode() != CONST_LEGACY && 1462 skip_init_check = var->mode() != CONST_LEGACY &&
1462 var->initializer_position() < proxy->position(); 1463 var->initializer_position() < proxy->position();
1463 } 1464 }
1464 1465
(...skipping 3819 matching lines...) Expand 10 before | Expand all | Expand 10 after
5284 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 5285 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
5285 Assembler::target_address_at(call_target_address, 5286 Assembler::target_address_at(call_target_address,
5286 unoptimized_code)); 5287 unoptimized_code));
5287 return OSR_AFTER_STACK_CHECK; 5288 return OSR_AFTER_STACK_CHECK;
5288 } 5289 }
5289 5290
5290 5291
5291 } } // namespace v8::internal 5292 } } // namespace v8::internal
5292 5293
5293 #endif // V8_TARGET_ARCH_X87 5294 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698