Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 90763004: GERRIT_PORT is no longer used in git_cl.py (Closed)

Created:
7 years ago by ukai
Modified:
7 years ago
Reviewers:
M-A Ruel, szager1
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M git_cl.py View 1 chunk +1 line, -2 lines 1 comment Download
M tests/git_cl_test.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
ukai
7 years ago (2013-11-27 06:48:27 UTC) #1
szager1
https://codereview.chromium.org/90763004/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/90763004/diff/1/git_cl.py#newcode1022 git_cl.py:1022: if 'GERRIT_HOST' in keyvals: We have not yet migrated ...
7 years ago (2013-11-27 09:13:07 UTC) #2
ukai
On 2013/11/27 09:13:07, szager1 wrote: > https://codereview.chromium.org/90763004/diff/1/git_cl.py > File git_cl.py (right): > > https://codereview.chromium.org/90763004/diff/1/git_cl.py#newcode1022 > ...
7 years ago (2013-11-27 12:44:57 UTC) #3
szager1
lgtm
7 years ago (2013-11-27 20:07:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ukai@chromium.org/90763004/1
7 years ago (2013-11-28 01:49:33 UTC) #5
commit-bot: I haz the power
7 years ago (2013-11-28 01:51:23 UTC) #6
Message was sent while issue was closed. 
Change committed as 237657

Powered by Google App Engine
This is Rietveld 408576698