git_cl.py - Issue 90763004: GERRIT_PORT is no longer used in git_cl.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cl.py

Issue 90763004: GERRIT_PORT is no longer used in git_cl.py (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: git_cl.py

diff --git a/git_cl.py b/git_cl.py

index 5e166324f10d66ba82eb5703c94eeca4f17692b5..90b054222d811ded700f8630c87c0bcbda2c08f0 100755

--- a/git_cl.py

+++ b/git_cl.py

@@ -1019,9 +1019,8 @@ def LoadCodereviewSettingsFromFile(fileobj):

SetProperty('tree-status-url', 'STATUS', unset_error_ok=True)

SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True)

- if 'GERRIT_HOST' in keyvals and 'GERRIT_PORT' in keyvals:

+ if 'GERRIT_HOST' in keyvals:

szager1 2013/11/27 09:13:07 We have not yet migrated off gerrit.chromium.org,

RunGit(['config', 'gerrit.host', keyvals['GERRIT_HOST']])

- RunGit(['config', 'gerrit.port', keyvals['GERRIT_PORT']])

if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals:

#should be of the form

« no previous file with comments | « no previous file | tests/git_cl_test.py » ('j') | no next file with comments »