Issue 907623002: Faster edge re-sort, drop trailing edges

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 907623002: Faster edge re-sort, drop trailing edges (Closed)

Created:
5 years, 10 months ago by reed2

Modified:
5 years, 10 months ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Faster edge re-sort, drop trailing edges (patchset #4 id:60001 of https://codereview.chromium.org/891613003/)" This reverts commit c319d075eab86cacfd7aba27859b72bbf8fc0a64. BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/2322115952c15c72a623837879cac1f85894b1b6

Patch Set 1 #

Patch Set 2 : account for aa in rightEdge #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -41 lines)			Patch
M	src/core/SkEdgeBuilder.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/core/SkEdgeBuilder.cpp	View		4 chunks	+7 lines, -7 lines	0 comments	Download
M	src/core/SkLineClipper.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkLineClipper.cpp	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	src/core/SkScan_Path.cpp	View	1	5 chunks	+34 lines, -28 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/907623002/20001

5 years, 10 months ago (2015-02-07 03:23:04 UTC) #2

commit-bot: I haz the power

Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/2322115952c15c72a623837879cac1f85894b1b6

5 years, 10 months ago (2015-02-07 03:29:19 UTC) #3

reed2

5 years, 10 months ago (2015-02-07 05:07:22 UTC) #4

Message was sent while issue was closed.

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/886503010/ by reed@chromium.org.

The reason for reverting is: still layout failures.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages