Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 907593002: Remove requirement for an error message for showing Intents (Closed)

Created:
5 years, 10 months ago by gone
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove requirement for an error message for showing Intents There are situations where we really don't mind if firing a [Pending]Intent doesn't return to Chrome. In these cases, alerting the user about Chrome dying is unnecessary. BUG=453170 Committed: https://crrev.com/1bb67aa78837a6ed8501b6d1f0081e8989c652e7 Cr-Commit-Position: refs/heads/master@{#315178}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -22 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java View 2 chunks +10 lines, -10 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/base/ActivityWindowAndroid.java View 3 chunks +6 lines, -4 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/base/WindowAndroid.java View 4 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
gone
5 years, 10 months ago (2015-02-07 00:52:55 UTC) #2
David Trainor- moved to gerrit
lgtm
5 years, 10 months ago (2015-02-07 00:59:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/907593002/1
5 years, 10 months ago (2015-02-07 02:16:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-07 03:55:10 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-07 03:56:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1bb67aa78837a6ed8501b6d1f0081e8989c652e7
Cr-Commit-Position: refs/heads/master@{#315178}

Powered by Google App Engine
This is Rietveld 408576698