chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java - Issue 907593002: Remove requirement for an error message for showing Intents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java

Issue 907593002: Remove requirement for an error message for showing Intents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java

index 75bf180e385c751d1ad678c97febca969e340f1c..3ddd7aee7126a71a239f37a73ccf26b4d2344b8d 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java

@@ -28,15 +28,15 @@ import org.chromium.ui.base.ActivityWindowAndroid;

public class SelectFileDialogTest extends ChromeShellTestBase {

private static final String DATA_URL = UrlUtils.encodeHtmlDataUri(

- "<html><head><meta name=\"viewport\"" +

- "content=\"width=device-width, initial-scale=2.0, maximum-scale=2.0\" /></head>" +

- "<body><form action=\"about:blank\">" +

- "<input id=\"input_file\" type=\"file\" /><br/>" +

- "<input id=\"input_file_multiple\" type=\"file\" multiple /><br />" +

- "<input id=\"input_image\" type=\"file\" accept=\"image/*\" capture /><br/>" +

- "<input id=\"input_audio\" type=\"file\" accept=\"audio/*\" capture />" +

- "</form>" +

- "</body></html>");

+ "<html><head><meta name=\"viewport\""

+ + "content=\"width=device-width, initial-scale=2.0, maximum-scale=2.0\" /></head>"

+ + "<body><form action=\"about:blank\">"

+ + "<input id=\"input_file\" type=\"file\" /><br/>"

+ + "<input id=\"input_file_multiple\" type=\"file\" multiple /><br />"

+ + "<input id=\"input_image\" type=\"file\" accept=\"image/*\" capture /><br/>"

+ + "<input id=\"input_audio\" type=\"file\" accept=\"audio/*\" capture />"

+ + "</form>"

+ + "</body></html>");

private ContentViewCore mContentViewCore;

private ActivityWindowAndroidForTest mActivityWindowAndroidForTest;

@@ -52,7 +52,7 @@ public class SelectFileDialogTest extends ChromeShellTestBase {

}

@Override

- public int showCancelableIntent(Intent intent, IntentCallback callback, int errorId) {

+ public int showCancelableIntent(Intent intent, IntentCallback callback, Integer errorId) {

lastIntent = intent;

lastCallback = callback;

return 1;

« no previous file with comments | « no previous file | ui/android/java/src/org/chromium/ui/base/ActivityWindowAndroid.java » ('j') | no next file with comments »