Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: chrome/browser/ui/toolbar/wrench_menu_model.cc

Issue 907473002: Polish UI of bookmark app creation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/wrench_menu_model.cc
diff --git a/chrome/browser/ui/toolbar/wrench_menu_model.cc b/chrome/browser/ui/toolbar/wrench_menu_model.cc
index 010f4d2de80d9361cc2f10852e6f29ceec0d25cb..3684113ec394f1544b838fc2ae6423a960b167a2 100644
--- a/chrome/browser/ui/toolbar/wrench_menu_model.cc
+++ b/chrome/browser/ui/toolbar/wrench_menu_model.cc
@@ -240,7 +240,18 @@ void ToolsMenuModel::Build(Browser* browser) {
#endif
if (extensions::util::IsNewBookmarkAppsEnabled()) {
- AddItemWithStringId(IDC_CREATE_HOSTED_APP, IDS_CREATE_HOSTED_APP);
+#if defined(OS_MACOSX)
+ int string_id = IDS_ADD_TO_DOCK;
+#elif defined(OS_WIN)
+ int string_id = IDS_ADD_TO_TASKBAR;
+#else
+ int string_id = IDS_ADD_TO_DESKTOP;
+#endif
+#if defined(USE_ASH)
+ if (browser->host_desktop_type() == chrome::HOST_DESKTOP_TYPE_ASH)
+ string_id = IDS_ADD_TO_SHELF;
+#endif
+ AddItemWithStringId(IDC_CREATE_HOSTED_APP, string_id);
AddSeparator(ui::NORMAL_SEPARATOR);
} else if (show_create_shortcuts) {
AddItemWithStringId(IDC_CREATE_SHORTCUTS, IDS_CREATE_SHORTCUTS);
« no previous file with comments | « chrome/browser/ui/ash/launcher/launcher_context_menu.cc ('k') | chrome/browser/ui/views/extensions/bookmark_app_bubble_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698