Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: scripts/slave/recipes/chromium_trybot_legacy.py

Issue 907393002: Don't always run the script tests if there are no compile targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/chromium_trybot_legacy.py
diff --git a/scripts/slave/recipes/chromium_trybot_legacy.py b/scripts/slave/recipes/chromium_trybot_legacy.py
index fb4c5feb19aae48003f7a58eedaec981991d72f0..34180c9d1d9f15c2d802c491b6f4154144803e43 100644
--- a/scripts/slave/recipes/chromium_trybot_legacy.py
+++ b/scripts/slave/recipes/chromium_trybot_legacy.py
@@ -439,7 +439,6 @@ def _GenStepsInternal(api):
# See if the patch needs to compile on the current platform.
# Don't run analyze for other projects, such as blink, as there aren't that
# many try jobs for them.
- requires_compile = True
if (isinstance(test_spec, dict) and
api.properties.get('patch_project') == 'chromium'):
analyze_config_file = bot_config['testing'].get('analyze_config_file',
@@ -451,6 +450,9 @@ def _GenStepsInternal(api):
compile_targets,
analyze_config_file)
+ if not requires_compile:
+ return [], bot_update_step
+
gtest_tests = filter_tests(gtest_tests, matching_exes)
tests = []
@@ -465,13 +467,6 @@ def _GenStepsInternal(api):
if api.platform.is_win:
tests.append(api.chromium.steps.MiniInstallerTest())
- if not requires_compile:
- # Even though the patch doesn't require compile, we'd still like to
- # run tests not depending on compiled targets (that's obviously not
- # covered by the "analyze" step).
- tests = [t for t in tests if not t.compile_targets(api)]
- return tests, bot_update_step
-
has_swarming_tests = any(t.uses_swarming for t in tests)
# Swarming uses Isolate to transfer files to swarming bots.

Powered by Google App Engine
This is Rietveld 408576698