PasswordStore: Clean up expectations about rewriting vectors of forms

chrome/browser/password_manager/native_backend_gnome_x.h

Index: chrome/browser/password_manager/native_backend_gnome_x.h
diff --git a/chrome/browser/password_manager/native_backend_gnome_x.h b/chrome/browser/password_manager/native_backend_gnome_x.h
index 438917a5e009e69a0d92fc5802e092d0db41d404..6108771b9b1521be87405ddbed57da16ee724f9f 100644
--- a/chrome/browser/password_manager/native_backend_gnome_x.h
+++ b/chrome/browser/password_manager/native_backend_gnome_x.h
@@ -120,7 +120,9 @@ class NativeBackendGnome : public PasswordStoreX::NativeBackend,
   // Adds a login form without checking for one to replace first.
   bool RawAddLogin(const autofill::PasswordForm& form);
 
-  // Reads PasswordForms from the keyring with the given autofillability state.
+  // Overwrites |forms| with blacklisted or autofillable, depending on
+  // |autofillable| being false or true, credentials from the keyring. In case

[engedy, 2015/02/25 15:17:48]

Phrasing suggestion (just an idea, I do not feel strongly about this): 

Retrieves all autofillable or all blacklisted credentials (depending on
|autofillable|) from the keyring into |forms|, overwriting the original contents
of |forms|. Returns true on success; returns false and erases |forms| on
failure.

[vabr (Chromium), 2015/03/09 10:56:18]

Done, with adjustment to not caring about |forms| on failure.

[engedy, 2015/03/09 13:33:17]

Acknowledged.

+  // of failures returns false and erases |forms|, otherwise returns true.
   bool GetLoginsList(bool autofillable,
                      ScopedVector<autofill::PasswordForm>* forms);