PasswordStore: Clean up expectations about rewriting vectors of forms

chrome/browser/password_manager/native_backend_gnome_x.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_NATIVE_BACKEND_GNOME_X_H_
 #define CHROME_BROWSER_PASSWORD_MANAGER_NATIVE_BACKEND_GNOME_X_H_
 
 // libgnome-keyring has been deprecated in favor of libsecret.
 // See: https://mail.gnome.org/archives/commits-list/2013-October/msg08876.html
 //
@@ skipping 102 matching lines @@
 
  private:
   enum TimestampToCompare {
     CREATION_TIMESTAMP,
     SYNC_TIMESTAMP,
   };
 
   // Adds a login form without checking for one to replace first.
   bool RawAddLogin(const autofill::PasswordForm& form);
 
-  // Reads PasswordForms from the keyring with the given autofillability state.
+  // Overwrites |forms| with blacklisted or autofillable, depending on
+  // |autofillable| being false or true, credentials from the keyring. In case

[engedy, 2015/02/25 15:17:48]

Phrasing suggestion (just an idea, I do not feel strongly about this): 

Retrieves all autofillable or all blacklisted credentials (depending on
|autofillable|) from the keyring into |forms|, overwriting the original contents
of |forms|. Returns true on success; returns false and erases |forms| on
failure.

[vabr (Chromium), 2015/03/09 10:56:18]

Done, with adjustment to not caring about |forms| on failure.

[engedy, 2015/03/09 13:33:17]

Acknowledged.

+  // of failures returns false and erases |forms|, otherwise returns true.
   bool GetLoginsList(bool autofillable,
                      ScopedVector<autofill::PasswordForm>* forms);
 
   // Helper for GetLoginsCreatedBetween().
   bool GetAllLogins(ScopedVector<autofill::PasswordForm>* forms);
 
   // Retrieves password created/synced in the time interval. Returns |true| if
   // the operation succeeded.
   bool GetLoginsBetween(base::Time get_begin,
                         base::Time get_end,
@@ skipping 13 matching lines @@
   // The local profile id, used to generate the app string.
   const LocalProfileId profile_id_;
 
   // The app string, possibly based on the local profile id.
   std::string app_string_;
 
   DISALLOW_COPY_AND_ASSIGN(NativeBackendGnome);
 };
 
 #endif  // CHROME_BROWSER_PASSWORD_MANAGER_NATIVE_BACKEND_GNOME_X_H_