components/password_manager/core/browser/password_store_default.cc - Issue 906973007: PasswordStore: Clean up expectations about rewriting vectors of forms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store_default.cc

Issue 906973007: PasswordStore: Clean up expectations about rewriting vectors of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Linux compile Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/login_database.cc ('K') | « components/password_manager/core/browser/login_database_win.cc ('k') | components/password_manager/core/browser/password_store_sync.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_store_default.cc

diff --git a/components/password_manager/core/browser/password_store_default.cc b/components/password_manager/core/browser/password_store_default.cc

index 88f6e9e45fe47f83a99df12fad70d62a5dd9e340..d20846f207e16102040b190c439aada009637221 100644

--- a/components/password_manager/core/browser/password_store_default.cc

+++ b/components/password_manager/core/browser/password_store_default.cc

@@ -115,8 +115,8 @@ ScopedVector<autofill::PasswordForm> PasswordStoreDefault::FillMatchingLogins(

const autofill::PasswordForm& form,

AuthorizationPromptPolicy prompt_policy) {

ScopedVector<autofill::PasswordForm> matched_forms;

- if (login_db_)

- login_db_->GetLogins(form, &matched_forms);

+ if (login_db_ && !login_db_->GetLogins(form, &matched_forms))

+ return ScopedVector<autofill::PasswordForm>();

return matched_forms.Pass();

}