components/password_manager/core/browser/login_database_win.cc - Issue 906973007: PasswordStore: Clean up expectations about rewriting vectors of forms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/login_database_win.cc

Issue 906973007: PasswordStore: Clean up expectations about rewriting vectors of forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Linux compile Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/login_database.cc ('K') | « components/password_manager/core/browser/login_database_posix.cc ('k') | components/password_manager/core/browser/password_store_default.cc » ('j') | components/password_manager/core/browser/password_store_default.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/login_database_win.cc

diff --git a/components/password_manager/core/browser/login_database_win.cc b/components/password_manager/core/browser/login_database_win.cc

index 19fd7dfe2438f7e5b8b89998d21bad77c8435d8b..2b2b2725573c21466fb57fe6cb1a674e94548c9a 100644

--- a/components/password_manager/core/browser/login_database_win.cc

+++ b/components/password_manager/core/browser/login_database_win.cc

@@ -9,17 +9,19 @@

namespace password_manager {

+// static

LoginDatabase::EncryptionResult LoginDatabase::EncryptedString(

const base::string16& plain_text,

- std::string* cipher_text) const {

+ std::string* cipher_text) {

if (OSCrypt::EncryptString16(plain_text, cipher_text))

return ENCRYPTION_RESULT_SUCCESS;

return ENCRYPTION_RESULT_ITEM_FAILURE;

}

+// static

LoginDatabase::EncryptionResult LoginDatabase::DecryptedString(

const std::string& cipher_text,

- base::string16* plain_text) const {

+ base::string16* plain_text) {

if (OSCrypt::DecryptString16(cipher_text, plain_text))

return ENCRYPTION_RESULT_SUCCESS;

return ENCRYPTION_RESULT_ITEM_FAILURE;