Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 906683002: Stronger comment for LAZY_STREAM macro. (Closed)

Created:
5 years, 10 months ago by chcunningham
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, erikwright+watch_chromium.org, wolenetz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stronger comment for LAZY_STREAM macro. Committed: https://crrev.com/f6a960842a2e3f23a3059fbf985a149ee36f115d Cr-Commit-Position: refs/heads/master@{#315158}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/logging.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
chcunningham
Hey Lei, I'm just adding a little not to LAZY_STREAM docs to mandate that the ...
5 years, 10 months ago (2015-02-06 21:08:18 UTC) #2
Lei Zhang
I wasn't involved in writing this code, so I'm trying to understand this as I ...
5 years, 10 months ago (2015-02-06 22:22:15 UTC) #3
chcunningham
On 2015/02/06 22:22:15, Lei Zhang wrote: > I wasn't involved in writing this code, so ...
5 years, 10 months ago (2015-02-06 22:37:17 UTC) #4
Lei Zhang
On 2015/02/06 22:37:17, chcunningham wrote: > On 2015/02/06 22:22:15, Lei Zhang wrote: > > I ...
5 years, 10 months ago (2015-02-06 22:38:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/906683002/1
5 years, 10 months ago (2015-02-07 00:31:46 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-07 01:58:47 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-07 02:00:03 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f6a960842a2e3f23a3059fbf985a149ee36f115d
Cr-Commit-Position: refs/heads/master@{#315158}

Powered by Google App Engine
This is Rietveld 408576698