base/logging.h - Issue 906683002: Stronger comment for LAZY_STREAM macro.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/logging.h

Issue 906683002: Stronger comment for LAZY_STREAM macro. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/logging.h

diff --git a/base/logging.h b/base/logging.h

index aa243a9e467816382cf43380a2b4df0ea8ead897..cc0a5aa11bc4de78eaf868d1af2e289236baf4f1 100644

--- a/base/logging.h

+++ b/base/logging.h

@@ -350,7 +350,7 @@ const LogSeverity LOG_0 = LOG_ERROR;

((verboselevel) <= ::logging::GetVlogLevel(__FILE__))

// Helper macro which avoids evaluating the arguments to a stream if

-// the condition doesn't hold.

+// the condition doesn't hold. Condition is evaluated once and only once.

#define LAZY_STREAM(stream, condition) \

!(condition) ? (void) 0 : ::logging::LogMessageVoidify() & (stream)

« no previous file with comments | « no previous file | no next file » | no next file with comments »