Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 906323003: [CSS Grid Layout] Columns set in percentages collapse to auto width (Closed)

Created:
5 years, 10 months ago by Manuel Rego
Modified:
5 years, 10 months ago
CC:
blink-reviews, jfernandez, blink-reviews-rendering, zoltan1, svillar, pdr+renderingwatchlist_chromium.org, Manuel Rego, leviw+renderwatch, Dominik Röttsches, jchaffraix+rendering, eae+blinkwatch_chromium.orgle
Base URL:
https://chromium.googlesource.com/chromium/blink.git@sergio-indefinite
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[CSS Grid Layout] Columns set in percentages collapse to auto width Based on a patch by svillar@igalia.com. RenderGrid::gridTrackSize() was not checking properly if the grid has or not an indefinite size. The condition was including auto which is not indefinite per se. For example, auto is definite if the containing block is definite. This patch adds 2 new new methods in RenderBox to determine if the grid is definite or not. BUG=407089 TEST=fast/css-grid-layout/percent-track-breadths-regarding-container-size.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189895

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -4 lines) Patch
A LayoutTests/fast/css-grid-layout/percent-track-breadths-regarding-container-size.html View 1 chunk +154 lines, -0 lines 0 comments Download
A LayoutTests/fast/css-grid-layout/percent-track-breadths-regarding-container-size-expected.txt View 1 chunk +50 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBox.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 2 chunks +49 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderGrid.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderGrid.cpp View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Manuel Rego
5 years, 10 months ago (2015-02-09 14:57:51 UTC) #2
eae
LGTM, I like the test!
5 years, 10 months ago (2015-02-09 21:11:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/906323003/1
5 years, 10 months ago (2015-02-10 11:27:51 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 12:46:25 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189895

Powered by Google App Engine
This is Rietveld 408576698