Source/core/rendering/RenderBox.h - Issue 906323003: [CSS Grid Layout] Columns set in percentages collapse to auto width

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBox.h

Issue 906323003: [CSS Grid Layout] Columns set in percentages collapse to auto width (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sergio-indefinite

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/percent-track-breadths-regarding-container-size-expected.txt ('k') | Source/core/rendering/RenderBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderBox.h

diff --git a/Source/core/rendering/RenderBox.h b/Source/core/rendering/RenderBox.h

index 40747183cc8a268ba40d4856421a95e5b93d9784..10821ec2a47f936b4969edc845dea5e33f7873cc 100644

--- a/Source/core/rendering/RenderBox.h

+++ b/Source/core/rendering/RenderBox.h

@@ -455,7 +455,10 @@ public:

virtual LayoutUnit computeReplacedLogicalWidth(ShouldComputePreferred = ComputeActual) const;

virtual LayoutUnit computeReplacedLogicalHeight() const;

+ static bool logicalWidthIsResolvableFromBlock(const RenderBlock* containingBlock);

+ bool hasDefiniteLogicalWidth() const;

static bool percentageLogicalHeightIsResolvableFromBlock(const RenderBlock* containingBlock, bool outOfFlowPositioned);

+ bool hasDefiniteLogicalHeight() const;

LayoutUnit computePercentageLogicalHeight(const Length& height) const;

// Block flows subclass availableWidth/Height to handle multi column layout (shrinking the width/height available to children when laying out.)