PlzNavigate: Support data urls

content/common/navigation_params.h

Index: content/common/navigation_params.h
diff --git a/content/common/navigation_params.h b/content/common/navigation_params.h
index 757d1a7fcc32f93c19ebb7f782badf670381a585..084874fb636b0b13b89d3c8d7f222149fff5dff0 100644
--- a/content/common/navigation_params.h
+++ b/content/common/navigation_params.h
@@ -23,6 +23,11 @@ class RefCountedMemory;
 namespace content {
 class NavigationEntry;
 
+// PlzNavigate
+// Helper function that returns true if a network request should be made for the
+// navigation to |url|.
+bool ShouldMakeNetworkRequestForNavigation(const GURL& url);

[clamy, 2015/02/16 18:00:44]

This function is used both in the renderer and the browser, so needs to be in
content/common. I thought it may be too much to create some navigation_utils
file in content/common just for it so put it there. If you have a better
suggestion for where it should be located, I'm happy to here it.

[Charlie Reis, 2015/02/18 00:43:25]

I think the premise on this one might be a bit flawed.  There's lots of
navigations that don't go to the network (e.g., fragments, pushState, file://,
chrome://, javascript:, etc).  Exposing this as a global helper function in
content/ is likely to lead to confusion about what it means.

Is there a way we can avoid it?

[clamy, 2015/02/20 17:05:59]

I moved it to NavigationRequest where the context should make sense.

+
 // The following structures hold parameters used during a navigation. In
 // particular they are used by FrameMsg_Navigate, FrameMsg_CommitNavigation and
 // FrameHostMsg_BeginNavigation.
@@ -38,7 +43,9 @@ struct CONTENT_EXPORT CommonNavigationParams {
                          FrameMsg_Navigate_Type::Value navigation_type,
                          bool allow_download,
                          base::TimeTicks ui_timestamp,
-                         FrameMsg_UILoadMetricsReportType::Value report_type);
+                         FrameMsg_UILoadMetricsReportType::Value report_type,
+                         const GURL& base_url_for_data_url,
+                         const GURL& history_url_for_data_url);
   ~CommonNavigationParams();
 
   // The URL to navigate to.
@@ -66,6 +73,14 @@ struct CONTENT_EXPORT CommonNavigationParams {
 
   // The report type to be used when recording the metric using |ui_timestamp|.
   FrameMsg_UILoadMetricsReportType::Value report_type;
+
+  // Base URL for use in blink's SubstituteData.
+  // Is only used with data: URLs.
+  GURL base_url_for_data_url;
+
+  // History URL for use in blink's SubstituteData.
+  // Is only used with data: URLs.
+  GURL history_url_for_data_url;
 };
 
 // PlzNavigate: parameters needed to start a navigation on the IO thread.