PlzNavigate: Support data urls

content/common/navigation_params.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_COMMON_NAVIGATION_PARAMS_H_
 #define CONTENT_COMMON_NAVIGATION_PARAMS_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/time/time.h"
 #include "content/common/content_export.h"
 #include "content/common/frame_message_enums.h"
 #include "content/public/common/page_state.h"
 #include "content/public/common/referrer.h"
 #include "ui/base/page_transition_types.h"
 #include "url/gurl.h"
 
 namespace base {
 class RefCountedMemory;
 }
 
 namespace content {
 class NavigationEntry;
 
+// PlzNavigate
+// Helper function that returns true if a network request should be made for the
+// navigation to |url|.
+bool ShouldMakeNetworkRequestForNavigation(const GURL& url);

[clamy, 2015/02/16 18:00:44]

This function is used both in the renderer and the browser, so needs to be in
content/common. I thought it may be too much to create some navigation_utils
file in content/common just for it so put it there. If you have a better
suggestion for where it should be located, I'm happy to here it.

[Charlie Reis, 2015/02/18 00:43:25]

I think the premise on this one might be a bit flawed.  There's lots of
navigations that don't go to the network (e.g., fragments, pushState, file://,
chrome://, javascript:, etc).  Exposing this as a global helper function in
content/ is likely to lead to confusion about what it means.

Is there a way we can avoid it?

[clamy, 2015/02/20 17:05:59]

I moved it to NavigationRequest where the context should make sense.

+
 // The following structures hold parameters used during a navigation. In
 // particular they are used by FrameMsg_Navigate, FrameMsg_CommitNavigation and
 // FrameHostMsg_BeginNavigation.
 // TODO(clamy): Depending on the avancement of the history refactoring move the
 // history parameters from FrameMsg_Navigate into one of the structs.
 
 // Used by all navigation IPCs.
 struct CONTENT_EXPORT CommonNavigationParams {
   CommonNavigationParams();
   CommonNavigationParams(const GURL& url,
                          const Referrer& referrer,
                          ui::PageTransition transition,
                          FrameMsg_Navigate_Type::Value navigation_type,
                          bool allow_download,
                          base::TimeTicks ui_timestamp,
-                         FrameMsg_UILoadMetricsReportType::Value report_type);
+                         FrameMsg_UILoadMetricsReportType::Value report_type,
+                         const GURL& base_url_for_data_url,
+                         const GURL& history_url_for_data_url);
   ~CommonNavigationParams();
 
   // The URL to navigate to.
   // PlzNavigate: May be modified when the navigation is ready to commit.
   GURL url;
 
   // The URL to send in the "Referer" header field. Can be empty if there is
   // no referrer.
   Referrer referrer;
 
   // The type of transition.
   ui::PageTransition transition;
 
   // Type of navigation.
   FrameMsg_Navigate_Type::Value navigation_type;
 
   // Allows the URL to be downloaded (true by default).
   // Avoid downloading when in view-source mode.
   bool allow_download;
 
   // Timestamp of the user input event that triggered this navigation. Empty if
   // the navigation was not triggered by clicking on a link or by receiving an
   // intent on Android.
   base::TimeTicks ui_timestamp;
 
   // The report type to be used when recording the metric using |ui_timestamp|.
   FrameMsg_UILoadMetricsReportType::Value report_type;
+
+  // Base URL for use in blink's SubstituteData.
+  // Is only used with data: URLs.
+  GURL base_url_for_data_url;
+
+  // History URL for use in blink's SubstituteData.
+  // Is only used with data: URLs.
+  GURL history_url_for_data_url;
 };
 
 // PlzNavigate: parameters needed to start a navigation on the IO thread.
 struct CONTENT_EXPORT BeginNavigationParams {
   // TODO(clamy): See if it is possible to reuse this in
   // ResourceMsg_Request_Params.
   BeginNavigationParams();
   BeginNavigationParams(std::string method,
                         std::string headers,
                         int load_flags,
@@ skipping 29 matching lines @@
 
   // The navigationStart time to expose through the Navigation Timing API to JS.
   base::TimeTicks browser_navigation_start;
 
   // TODO(clamy): Move the redirect chain here.
 };
 
 }  // namespace content
 
 #endif  // CONTENT_COMMON_NAVIGATION_PARAMS_H_