Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 906193002: Turn a bunch of ASSERTs into graceful failures when compiling listeners (Closed)

Created:
5 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 10 months ago
Reviewers:
haraken, dcarney, Yang
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Turn a bunch of ASSERTs into graceful failures when compiling listeners BUG=456192 R=yangguo@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189796

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
A LayoutTests/security/lazy-event-listener.html View 1 1 chunk +9 lines, -0 lines 0 comments Download
A + LayoutTests/security/lazy-event-listener-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/bindings/core/v8/V8LazyEventListener.cpp View 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
jochen (gone - plz use gerrit)
5 years, 10 months ago (2015-02-09 08:20:01 UTC) #1
dcarney
lgtm
5 years, 10 months ago (2015-02-09 10:02:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/906193002/20001
5 years, 10 months ago (2015-02-09 10:08:31 UTC) #5
Yang
On 2015/02/09 10:08:31, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 10 months ago (2015-02-09 10:18:32 UTC) #6
haraken
LGTM
5 years, 10 months ago (2015-02-09 11:23:59 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/121159) Timed out jobs are ...
5 years, 10 months ago (2015-02-09 12:26:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/906193002/20001
5 years, 10 months ago (2015-02-09 12:33:10 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 13:29:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189796

Powered by Google App Engine
This is Rietveld 408576698