app_list search results relevance scores are clamped to [0, 1] range.

app_list search results relevance scores are clamped to [0, 1] range.

Since the scores come from an external service, they should be forced
into the [0, 1] range, instead of assuming they are in that range. (We
cannot accept any arbitrary score, because then that would allow the
service to prioritize its results over other services, and would also
break the "known results" prioritization scheme.)

BUG=456641
Committed: https://crrev.com/d39ded9006f4c29f814895ea5aa88bdb61c9cb0c
Cr-Commit-Position: refs/heads/master@{#315275}

[Matt Giuca, 2015-02-09 03:41:32]

mgiuca@chromium.org changed reviewers:
+ calamity@chromium.org

[calamity, 2015-02-09 03:52:28]

lgtm

https://codereview.chromium.org/906133003/diff/40001/ui/app_list/search/mixer.cc
File ui/app_list/search/mixer.cc (right):

https://codereview.chromium.org/906133003/diff/40001/ui/app_list/search/mixer...
ui/app_list/search/mixer.cc:70: double relevance =
std::min(std::max(result->relevance(), 0.0), 1.0);
Precautionary? Or was this actually DCHECKing?

[Matt Giuca, 2015-02-09 04:05:29]

https://codereview.chromium.org/906133003/diff/40001/ui/app_list/search/mixer.cc
File ui/app_list/search/mixer.cc (right):

https://codereview.chromium.org/906133003/diff/40001/ui/app_list/search/mixer...
ui/app_list/search/mixer.cc:70: double relevance =
std::min(std::max(result->relevance(), 0.0), 1.0);
Precautionary.

(We can't have a DCHECK that relies on external services to behave.)

[Matt Giuca, 2015-02-09 04:39:37]

New patchsets have been uploaded after l-g-t-m from calamity@chromium.org

[Matt Giuca, 2015-02-09 06:13:29]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2015-02-09 06:13:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/906133003/60001

[commit-bot: I haz the power, 2015-02-09 07:02:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-09 07:03:24]

Patchset 4 (id:??) landed as
https://crrev.com/d39ded9006f4c29f814895ea5aa88bdb61c9cb0c
Cr-Commit-Position: refs/heads/master@{#315275}