app_list search results relevance scores are clamped to [0, 1] range.

ui/app_list/search/mixer_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <set>
 #include <string>
 
 #include "base/memory/scoped_vector.h"
 #include "base/strings/string16.h"
 #include "base/strings/stringprintf.h"
@@ skipping 39 matching lines @@
 
   int instance_id_;
 
   DISALLOW_COPY_AND_ASSIGN(TestSearchResult);
 };
 int TestSearchResult::instantiation_count = 0;
 
 class TestSearchProvider : public SearchProvider {
  public:
   explicit TestSearchProvider(const std::string& prefix)
-      : prefix_(prefix), count_(0) {}
+      : prefix_(prefix), count_(0), bad_relevance_range_(false) {}
   ~TestSearchProvider() override {}
 
   // SearchProvider overrides:
   void Start(bool is_voice_query, const base::string16& query) override {
     ClearResults();
     for (size_t i = 0; i < count_; ++i) {
       const std::string id =
           base::StringPrintf("%s%d", prefix_.c_str(), static_cast<int>(i));
-      const double relevance = 1.0 - i / 10.0;
+      double relevance = 1.0 - i / 10.0;
+      // If bad_relevance_range_, change the relevances to give results outside
+      // of the canonical [0.0, 1.0] range.
+      if (bad_relevance_range_)
+        relevance = 10.0 - i * 10;
       TestSearchResult* result = new TestSearchResult(id, relevance);
       if (voice_result_indices.find(i) != voice_result_indices.end())
         result->set_voice_result(true);
       Add(scoped_ptr<SearchResult>(result).Pass());
     }
   }
   void Stop() override {}
 
   void set_prefix(const std::string& prefix) { prefix_ = prefix; }
   void set_count(size_t count) { count_ = count; }
   void set_as_voice_result(size_t index) { voice_result_indices.insert(index); }
+  void set_bad_relevance_range() { bad_relevance_range_ = true; }
 
  private:
   std::string prefix_;
   size_t count_;
+  bool bad_relevance_range_;
   // Indices of results that will have the |voice_result| flag set.
   std::set<size_t> voice_result_indices;
 
   DISALLOW_COPY_AND_ASSIGN(TestSearchProvider);
 };
 
 class MixerTest : public testing::Test {
  public:
   MixerTest() : is_voice_query_(false) {}
   ~MixerTest() override {}
@@ skipping 162 matching lines @@
   set_is_voice_query(true);
   RunQuery();
   EXPECT_EQ("omnibox1,omnibox0,omnibox2", GetResults());
 
   // All voice results should appear before non-voice results.
   omnibox_provider()->set_as_voice_result(2);
   RunQuery();
   EXPECT_EQ("omnibox1,omnibox2,omnibox0", GetResults());
 }
 
+TEST_F(MixerTest, BadRelevanceRange) {
+  // This gives relevance scores: (10.0, 0.0). Even though providers are
+  // supposed to give scores within the range [0.0, 1.0], we cannot rely on
+  // providers to do this, since they retrieve results from disparate and
+  // unreliable sources (like the Google+ API).
+  people_provider()->set_bad_relevance_range();
+  people_provider()->set_count(2);
+
+  // Give a massive boost to the second result.
+  AddKnownResult("people1", PERFECT_PRIMARY);
+
+  RunQuery();
+
+  // If the results are correctly clamped to the range [0.0, 1.0], the boost to
+  // "people1" will push it over the first result. If not, the massive base
+  // score of "people0" will erroneously keep it on top.
+  EXPECT_EQ("people1,people0", GetResults());
+}
+
 TEST_F(MixerTest, Publish) {
   scoped_ptr<SearchResult> result1(new TestSearchResult("app1", 0));
   scoped_ptr<SearchResult> result2(new TestSearchResult("app2", 0));
   scoped_ptr<SearchResult> result3(new TestSearchResult("app3", 0));
   scoped_ptr<SearchResult> result3_copy = result3->Duplicate();
   scoped_ptr<SearchResult> result4(new TestSearchResult("app4", 0));
   scoped_ptr<SearchResult> result5(new TestSearchResult("app5", 0));
 
   AppListModel::SearchResults ui_results;
 
@@ skipping 70 matching lines @@
   EXPECT_EQ(old_ui_result_ids[0],
             TestSearchResult::GetInstanceId(ui_results.GetItemAt(3)));
   EXPECT_EQ(old_ui_result_ids[1],
             TestSearchResult::GetInstanceId(ui_results.GetItemAt(0)));
   EXPECT_EQ(old_ui_result_ids[2],
             TestSearchResult::GetInstanceId(ui_results.GetItemAt(2)));
 }
 
 }  // namespace test
 }  // namespace app_list