Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 905803002: Fix log spam on 10.6 due to NSWindowFullScreenButton. (Closed)

Created:
5 years, 10 months ago by Alexei Svitkine (slow)
Modified:
5 years, 10 months ago
Reviewers:
erikchen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix log spam on 10.6 due to NSWindowFullScreenButton. NSWindowFullScreenButton is a 10.7 addition and calling -standardWindowButton: with it on 10.6 results in log spam of the form: "unrecognized button type 7" BUG=none Committed: https://crrev.com/34f8293d798313b84fd29ca804a8c50a797dc55f Cr-Commit-Position: refs/heads/master@{#315089}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Alexei Svitkine (slow)
5 years, 10 months ago (2015-02-06 16:21:45 UTC) #2
erikchen
lgtm
5 years, 10 months ago (2015-02-06 18:28:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/905803002/1
5 years, 10 months ago (2015-02-06 18:33:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/31610)
5 years, 10 months ago (2015-02-06 19:01:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/905803002/20001
5 years, 10 months ago (2015-02-06 19:21:56 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-06 19:53:32 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 19:54:24 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/34f8293d798313b84fd29ca804a8c50a797dc55f
Cr-Commit-Position: refs/heads/master@{#315089}

Powered by Google App Engine
This is Rietveld 408576698