chrome/browser/ui/cocoa/browser_window_controller_private.mm - Issue 905803002: Fix log spam on 10.6 due to NSWindowFullScreenButton.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_private.mm

Issue 905803002: Fix log spam on 10.6 due to NSWindowFullScreenButton. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/browser_window_controller_private.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.mm b/chrome/browser/ui/cocoa/browser_window_controller_private.mm

index f2c086b0882389ef0b9d17fde3ed128909913441..f16f8aa86af7e9a56ffee0bb47a4ee4b44c94483 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller_private.mm

+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.mm

@@ -842,8 +842,9 @@ willPositionSheet:(NSWindow*)sheet

[presentationModeController_ toolbarFraction]];

[layout setHasTabStrip:[self hasTabStrip]];

- NSButton* fullScreenButton =

- [[self window] standardWindowButton:NSWindowFullScreenButton];

+ // NSWindowFullScreenButton is 10.7+ and results in log spam on 10.6 if used.

+ NSButton* fullScreenButton = base::mac::IsOSSnowLeopard() ?

+ nil : [[self window] standardWindowButton:NSWindowFullScreenButton];

[layout setFullscreenButtonFrame:fullScreenButton ? [fullScreenButton frame]

: NSZeroRect];

if ([self shouldShowAvatar]) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »