Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 905713002: Push API: Fix registration failing because app handler is missing (Closed)

Created:
5 years, 10 months ago by johnme
Modified:
5 years, 10 months ago
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@countgrace
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Push API: Fix registration failing because app handler is missing A regression was introduced by https://codereview.chromium.org/823993003 whereby the first push registration only works if the user is signed in, and hence an AppHandler happens to be added by sync. Instead Push should add AppHandlers for pending registrations so there is always an app handler while we are trying to register. BUG=456054 Committed: https://crrev.com/126aba183c8281e3ba2351ed595b53bd1b2f3d6f Cr-Commit-Position: refs/heads/master@{#315019}

Patch Set 1 #

Patch Set 2 : Avoid decreasing too often #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -26 lines) Patch
M chrome/browser/services/gcm/push_messaging_service_impl.h View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/services/gcm/push_messaging_service_impl.cc View 1 9 chunks +35 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
johnme
5 years, 10 months ago (2015-02-06 11:52:29 UTC) #2
Michael van Ouwerkerk
lgtm Nice way of also handling multiple pending registration attempts.
5 years, 10 months ago (2015-02-06 12:02:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/905713002/20001
5 years, 10 months ago (2015-02-06 12:31:26 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-06 13:22:57 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 13:24:07 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/126aba183c8281e3ba2351ed595b53bd1b2f3d6f
Cr-Commit-Position: refs/heads/master@{#315019}

Powered by Google App Engine
This is Rietveld 408576698